Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: components/ntp_tiles/BUILD.gn

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)
Patch Set: Addressed comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 } 7 }
8 8
9 static_library("ntp_tiles") { 9 static_library("ntp_tiles") {
10 sources = [ 10 sources = [
(...skipping 28 matching lines...) Expand all
39 "//components/suggestions", 39 "//components/suggestions",
40 ] 40 ]
41 deps = [ 41 deps = [
42 "//components/data_use_measurement/core", 42 "//components/data_use_measurement/core",
43 "//components/favicon/core", 43 "//components/favicon/core",
44 "//components/favicon_base", 44 "//components/favicon_base",
45 "//components/google/core/browser", 45 "//components/google/core/browser",
46 "//components/image_fetcher", 46 "//components/image_fetcher",
47 "//components/pref_registry", 47 "//components/pref_registry",
48 "//components/prefs", 48 "//components/prefs",
49 "//components/rappor/public",
49 "//components/search_engines", 50 "//components/search_engines",
50 "//components/url_formatter", 51 "//components/url_formatter",
51 "//components/variations", 52 "//components/variations",
52 "//components/variations/service", 53 "//components/variations/service",
53 ] 54 ]
54 55
55 if (is_android) { 56 if (is_android) {
56 deps += [ "android:ntp_tiles_jni_headers" ] 57 deps += [ "android:ntp_tiles_jni_headers" ]
57 } 58 }
58 } 59 }
(...skipping 11 matching lines...) Expand all
70 71
71 public_deps = [ 72 public_deps = [
72 "//base", 73 "//base",
73 ] 74 ]
74 } 75 }
75 76
76 source_set("unit_tests") { 77 source_set("unit_tests") {
77 testonly = true 78 testonly = true
78 sources = [ 79 sources = [
79 "icon_cacher_unittest.cc", 80 "icon_cacher_unittest.cc",
81 "metrics_unittest.cc",
80 "most_visited_sites_unittest.cc", 82 "most_visited_sites_unittest.cc",
81 "popular_sites_unittest.cc", 83 "popular_sites_unittest.cc",
82 ] 84 ]
83 85
84 deps = [ 86 deps = [
85 ":json_unsafe_parser", 87 ":json_unsafe_parser",
86 ":ntp_tiles", 88 ":ntp_tiles",
87 "//base/test:test_support", 89 "//base/test:test_support",
88 "//components/favicon/core", 90 "//components/favicon/core",
89 "//components/favicon_base", 91 "//components/favicon_base",
90 "//components/image_fetcher", 92 "//components/image_fetcher",
91 "//components/pref_registry:test_support", 93 "//components/pref_registry:test_support",
94 "//components/rappor:test_support",
92 "//net:test_support", 95 "//net:test_support",
93 "//testing/gmock", 96 "//testing/gmock",
94 "//testing/gtest", 97 "//testing/gtest",
95 "//ui/gfx:test_support", 98 "//ui/gfx:test_support",
96 ] 99 ]
97 } 100 }
98 101
99 if (is_android) { 102 if (is_android) {
100 java_cpp_enum("ntp_tiles_enums_java") { 103 java_cpp_enum("ntp_tiles_enums_java") {
101 sources = [ 104 sources = [
102 "metrics.h", 105 "metrics.h",
103 "ntp_tile_source.h", 106 "ntp_tile_source.h",
104 ] 107 ]
105 } 108 }
106 } 109 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698