ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type.

chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/after_startup_task_utils.h"
+#include "chrome/browser/browser_process.h"

[Marc Treib, 2016/12/08 13:52:59]

Not needed I think?

[mastiz, 2016/12/08 14:02:51]

Removed leftover, thanks.

 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/common/search/search_urls.h"
 #include "chrome/common/url_constants.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/ntp_tiles/metrics.h"
 #include "components/sync_sessions/sessions_sync_manager.h"
 #include "components/sync_sessions/sync_sessions_metrics.h"
 #include "content/public/browser/navigation_details.h"
@@ skipping 126 matching lines @@
 }
 
 void NTPUserDataLogger::EmitNtpStatistics(base::TimeDelta load_time) {
   // We only send statistics once per page.
   if (has_emitted_)
     return;
 
   DVLOG(1) << "Emitting NTP load time: " << load_time << ", "
            << "number of tiles: " << impression_was_logged_.count();
 
-  std::vector<std::pair<ntp_tiles::NTPTileSource,
-                        ntp_tiles::metrics::MostVisitedTileType>>
-      tiles;
+  std::vector<ntp_tiles::metrics::TileImpression> tiles;
   bool has_server_side_suggestions = false;
   for (int i = 0; i < kNumMostVisited; i++) {
     if (!impression_was_logged_[i]) {
       break;
     }
     if (impression_tile_source_[i] ==
         ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE) {
       has_server_side_suggestions = true;
     }
+    // No URL passed since we're not interested in favicon-related Rappor
+    // metrics.
     tiles.emplace_back(impression_tile_source_[i],
-                       ntp_tiles::metrics::THUMBNAIL);
+                       ntp_tiles::metrics::THUMBNAIL, GURL::EmptyGURL());

[Marc Treib, 2016/12/08 13:52:59]

From the comment on EmptyGURL(), I think in this case just "GURL()" would be
preferred.

[mastiz, 2016/12/08 14:02:51]

Done.

   }
-  ntp_tiles::metrics::RecordPageImpression(tiles);
+
+  // Not interested in Rappor metrics.
+  ntp_tiles::metrics::RecordPageImpression(tiles, /*rappor_service=*/nullptr);
 
   LogLoadTimeHistogram("NewTabPage.LoadTime", load_time);
 
   // Split between ML and MV.
   std::string type = has_server_side_suggestions ? "MostLikely" : "MostVisited";
   LogLoadTimeHistogram("NewTabPage.LoadTime." + type, load_time);
 
   // Split between Web and Local.
   std::string variant = ntp_url_.SchemeIsHTTPOrHTTPS() ? "Web" : "LocalNTP";
   LogLoadTimeHistogram("NewTabPage.LoadTime." + variant, load_time);
 
   // Split between Startup and non-startup.
   std::string status = during_startup_ ? "Startup" : "NewTab";
   LogLoadTimeHistogram("NewTabPage.LoadTime." + status, load_time);
 
   has_emitted_ = true;
   during_startup_ = false;
 }