Fix a bug that GPU process may fail to launch in RDP sessions

Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f406d19447ab1352ce2b2b6e260a0b9d2e4a9e41
Cr-Commit-Position: refs/heads/master@{#437492}

[Jiawei, 2016-12-06 15:22:32]

Description was changed from

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
==========

to

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Jiawei, 2016-12-06 15:26:10]

Description was changed from

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Jiawei, 2016-12-06 15:26:11]

jiawei.shao@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, yang.gu@intel.com,
yunchao.he@intel.com, zmo@chromium.org

[Zhenyao Mo, 2016-12-07 21:39:08]

On 2016/12/06 15:26:11, Jiawei wrote:
> mailto:jiawei.shao@intel.com changed reviewers:
> + mailto:kbr@chromium.org, mailto:qiankun.miao@intel.com,
mailto:yang.gu@intel.com,
> mailto:yunchao.he@intel.com, mailto:zmo@chromium.org

lgtm if you verify this gets you GPU in remote desktop

[Jiawei, 2016-12-09 07:09:44]

The CQ bit was checked by jiawei.shao@intel.com

[commit-bot: I haz the power, 2016-12-09 07:10:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 07:48:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481267384861680, "parent_rev":
"c31329f71023c6133e2a9ab397f4427a07e45e1e", "commit_rev":
"e6fad4ecaad668a78d3bf45b35900f0f1e301ff2"}

[commit-bot: I haz the power, 2016-12-09 07:48:52]

Description was changed from

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-09 07:48:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 07:50:59]

Description was changed from

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug that GPU process may fail to launch in RDP sessions

Chrome calls EnumDisplayDevices() to get details about display devices.
On some Windows machines EnumDisplayDevices() can only get the mirror
driver "RDPUDD Chained DD" with empty DeviceID and no physical display
devices when Chrome is opened in a Remote Desktop session, which will
cause the failure of launching the GPU process.

This patch fixes this issue by skipping the check of DeviceID when the
primary display device is "RDPUDD Chained DD" according to the result
of EnumDisplayDevices() so that Chrome can obtain GPU information
afterwards (in CollectDriverInfoD3D()).

BUG=671539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f406d19447ab1352ce2b2b6e260a0b9d2e4a9e41
Cr-Commit-Position: refs/heads/master@{#437492}
==========

[commit-bot: I haz the power, 2016-12-09 07:51:00]

Patchset 1 (id:??) landed as
https://crrev.com/f406d19447ab1352ce2b2b6e260a0b9d2e4a9e41
Cr-Commit-Position: refs/heads/master@{#437492}