ShapeDetection: Eliminate DetectorType enum in ShapeDetector.cpp

This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
Committed: https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400
Cr-Commit-Position: refs/heads/master@{#436856}

[xianglu, 2016-12-06 01:00:26]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:00:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 01:10:39]

Description was changed from

==========
ShapeDetection: Eliminate DetectorType in ShapeDetector.cpp

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType in ShapeDetector.cpp. The real work (calling through mojo
interface Detect()) is moved to FaceDetector and BarcodeDetector,respectively,
so that ShapeDetector only does the shared work of processing image source.

BUG=646083, 659139
==========

[xianglu, 2016-12-06 01:11:21]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType in ShapeDetector.cpp. The real work (calling through mojo
interface Detect()) is moved to FaceDetector and BarcodeDetector,respectively,
so that ShapeDetector only does the shared work of processing image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType in ShapeDetector.cpp. The real work (calling through
mojo interface Detect()) is moved to FaceDetector and BarcodeDetector,
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

[xianglu, 2016-12-06 01:12:44]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType in ShapeDetector.cpp. The real work (calling through
mojo interface Detect()) is moved to FaceDetector and BarcodeDetector,
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType argument in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

[xianglu, 2016-12-06 01:13:05]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType argument in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType argument in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

[xianglu, 2016-12-06 01:20:58]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:21:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 01:22:20]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType argument in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

[xianglu, 2016-12-06 01:22:33]

Patchset #1 (id:1) has been deleted

[xianglu, 2016-12-06 01:23:47]

xianglu@chromium.org changed reviewers:
+ mcasas@chromium.org

[xianglu, 2016-12-06 01:23:48]

PTAL.

[commit-bot: I haz the power, 2016-12-06 03:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 03:02:17]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-12-06 04:40:20]

Looking good, but still some more
moving things around needed.

https://codereview.chromium.org/2557513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:146:
m_imageHeight = img->naturalHeight();
Instead of holding on to |m_sharedBufferHandle|,
|m_imageWidth| and |m_imageHeight|, add a 
virtual ScriptPromise DoDetect(mojo::SharedBufferHandle, int, int) = 0;

and implement it in {Barcode/Face}Detector (e.g. it'd
encompass the current l.40-52); here you'd just need a 
return DoDetect(...); 

In this way you can keep the signature (and name) of 
these methods: plus it's more robust to return a 
Promise than a boolean, since in the latter case the 
caller must parse a true/false and then trust the method
to have updated correctly the Promise by means
of the Resolver...

[xianglu, 2016-12-06 20:14:35]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 20:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 20:16:54]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[xianglu, 2016-12-06 20:17:07]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-12-06 20:17:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 20:20:10]

PTAL.

https://codereview.chromium.org/2557513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:146:
m_imageHeight = img->naturalHeight();
On 2016/12/06 04:40:20, mcasas wrote:
> Instead of holding on to |m_sharedBufferHandle|,
> |m_imageWidth| and |m_imageHeight|, add a 
> virtual ScriptPromise DoDetect(mojo::SharedBufferHandle, int, int) = 0;
> 
> and implement it in {Barcode/Face}Detector (e.g. it'd
> encompass the current l.40-52); here you'd just need a 
> return DoDetect(...); 
> 
> In this way you can keep the signature (and name) of 
> these methods: plus it's more robust to return a 
> Promise than a boolean, since in the latter case the 
> caller must parse a true/false and then trust the method
> to have updated correctly the Promise by means
> of the Resolver...

Done.

[xianglu, 2016-12-06 20:39:41]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 20:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-12-06 20:40:12]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-12-06 20:40:13]

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
(right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:22:
DCHECK(!m_barcodeService.is_bound());
Just DCHECK(!m_barcodeService), though in the constructor it seems like this is
check is superfluous.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:46:
sharedBufferHandle.reset();
This line should be a no-op because std::move(sharedBufferHandle) will have
invalidated this variable.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h:36: int);
Blink style allows unnamed parameters when the type name makes the variable name
redundant. Here it is unclear so please name your parameters.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:25:
DCHECK(!m_faceService.is_bound());
Same comment.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:50:
sharedBufferHandle.reset();
Same comment here.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:37: int);
Same comment here.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:77: resolver,
static_cast<HTMLImageElement*>(imageSourceInternal));
It seems to me that since this set of if statements mirror
toImageSourceInternal()'s logic we could avoid these casts by just calling the
methods like imageSource.getAsHTMLImageElement() here.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h:41: int) = 0;
Same comment.

[xianglu, 2016-12-06 20:40:17]

Patchset #3 (id:60002) has been deleted

[xianglu, 2016-12-06 20:41:34]

Patchset #3 (id:90001) has been deleted

[xianglu, 2016-12-06 21:23:51]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:24:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 21:36:04]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 21:36:35]

Patchset #3 (id:110001) has been deleted

[xianglu, 2016-12-06 21:46:24]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:46:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 21:47:02]

Patchset #3 (id:130001) has been deleted

[xianglu, 2016-12-06 22:25:34]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:26:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 22:30:35]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[xianglu, 2016-12-06 22:30:47]

Patchset #4 (id:170001) has been deleted

[commit-bot: I haz the power, 2016-12-06 22:30:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-06 22:31:56]

PTAL.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
(right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:22:
DCHECK(!m_barcodeService.is_bound());
On 2016/12/06 20:40:12, Reilly Grant wrote:
> Just DCHECK(!m_barcodeService), though in the constructor it seems like this
is
> check is superfluous.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp:46:
sharedBufferHandle.reset();
On 2016/12/06 20:40:12, Reilly Grant wrote:
> This line should be a no-op because std::move(sharedBufferHandle) will have
> invalidated this variable.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h:36: int);
On 2016/12/06 20:40:12, Reilly Grant wrote:
> Blink style allows unnamed parameters when the type name makes the variable
name
> redundant. Here it is unclear so please name your parameters.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:25:
DCHECK(!m_faceService.is_bound());
On 2016/12/06 20:40:13, Reilly Grant wrote:
> Same comment.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:50:
sharedBufferHandle.reset();
On 2016/12/06 20:40:13, Reilly Grant wrote:
> Same comment here.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:37: int);
On 2016/12/06 20:40:13, Reilly Grant wrote:
> Same comment here.

Done.

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:77: resolver,
static_cast<HTMLImageElement*>(imageSourceInternal));
On 2016/12/06 20:40:13, Reilly Grant wrote:
> It seems to me that since this set of if statements mirror
> toImageSourceInternal()'s logic we could avoid these casts by just calling the
> methods like imageSource.getAsHTMLImageElement() here.

Removed duplicated logic. I think the only trade-off here is that since
wouldTaintOrigin() only works on an explicit canvas source, the elements need to
be checked separately in their detectShapesOn...().

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h (right):

https://codereview.chromium.org/2557513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h:41: int) = 0;
On 2016/12/06 20:40:13, Reilly Grant wrote:
> Same comment.

Done.

[mcasas, 2016-12-06 22:50:12]

lgtm with the comment addressed.

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:61: return
detectShapesOnImageElement(scriptState, resolver,
Hmm after removing toImageSourceInternal() 
you have to pass ScriptState* scriptState to 
each method and replicate the tainting logic:

  if (bla->wouldTaintOrigin(
          scriptState->getExecutionContext()->getSecurityOrigin())) {
    resolver->reject(
        DOMException::create(SecurityError, "Source would taint origin."));
    return promise;
  }

which is very unfortunate. Instead, leave
static CanvasImageSource* toImageSourceInternal(
as it was but, like reillyg@ suggests, use the
appropriate 
  imageSource.getAsFoo()
methods instead of the static_cast<>s

[Reilly Grant (use Gerrit), 2016-12-06 22:58:38]

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:45:
m_faceDetectorOptions.Clone(),
Just a note for the future, we could add the options to the IPC used to acquire
m_faceService so that it doesn't have to be sent with every detection request.

This means we would add a Mojo service FaceDetectorProvider which has a method:

Create(FaceDetector& request, FaceDetectorOptions options);

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:64:
!static_cast<ImageBitmap*>(imageSource.getAsImageBitmap())
getAsImageBitmap() already returns an ImageBitmap* so no cast is necessary. I
would write this as:

} else if (imageSource.isImageBitmap()) {
  ImageBitmap* imageBitmap = imageSource.getAsImageBitmap();
  if (!imageBitmap.isNeutered()) {
    return detectShapesOnImageBitmap(scriptState, resolver, imageBitmap);
  }
} ...

[Reilly Grant (use Gerrit), 2016-12-06 23:03:42]

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:61: return
detectShapesOnImageElement(scriptState, resolver,
On 2016/12/06 at 22:50:12, mcasas wrote:
> Hmm after removing toImageSourceInternal() 
> you have to pass ScriptState* scriptState to 
> each method and replicate the tainting logic:
> 
>   if (bla->wouldTaintOrigin(
>           scriptState->getExecutionContext()->getSecurityOrigin())) {
>     resolver->reject(
>         DOMException::create(SecurityError, "Source would taint origin."));
>     return promise;
>   }
> 
> which is very unfortunate. Instead, leave
> static CanvasImageSource* toImageSourceInternal(
> as it was but, like reillyg@ suggests, use the
> appropriate 
>   imageSource.getAsFoo()
> methods instead of the static_cast<>s

How about:

CanvasImageSource* canvasImageSource;
if (imageSource.isFoo()) {
  canvasImageSource = imageSource.asFoo();
} else if ... {

} else {
  NOTIMPLEMENTED etc from below.
}

// tainting logic on canvasImageSource

if (imageSource.isFoo()) {
  return detectAsFoo();
} else if ...

[mcasas, 2016-12-06 23:10:05]

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2557513003/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:61: return
detectShapesOnImageElement(scriptState, resolver,
On 2016/12/06 23:03:42, Reilly Grant wrote:
> On 2016/12/06 at 22:50:12, mcasas wrote:
> > Hmm after removing toImageSourceInternal() 
> > you have to pass ScriptState* scriptState to 
> > each method and replicate the tainting logic:
> > 
> >   if (bla->wouldTaintOrigin(
> >           scriptState->getExecutionContext()->getSecurityOrigin())) {
> >     resolver->reject(
> >         DOMException::create(SecurityError, "Source would taint origin."));
> >     return promise;
> >   }
> > 
> > which is very unfortunate. Instead, leave
> > static CanvasImageSource* toImageSourceInternal(
> > as it was but, like reillyg@ suggests, use the
> > appropriate 
> >   imageSource.getAsFoo()
> > methods instead of the static_cast<>s
> 
> How about:
> 
> CanvasImageSource* canvasImageSource;
> if (imageSource.isFoo()) {
>   canvasImageSource = imageSource.asFoo();
> } else if ... {
> 
> } else {
>   NOTIMPLEMENTED etc from below.
> }
> 
> // tainting logic on canvasImageSource
> 
> if (imageSource.isFoo()) {
>   return detectAsFoo();
> } else if ...

That looks nice, works for me!

[xianglu, 2016-12-06 23:56:15]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 23:56:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:04:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[xianglu, 2016-12-07 00:06:30]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[xianglu, 2016-12-07 00:06:58]

Patchset #5 (id:210001) has been deleted

[commit-bot: I haz the power, 2016-12-07 00:07:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-07 00:09:14]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 00:09:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-12-07 00:09:36]

Patchset #5 (id:230001) has been deleted

[xianglu, 2016-12-07 00:12:20]

reillyg@ PTAL.

[commit-bot: I haz the power, 2016-12-07 00:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:17:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Reilly Grant (use Gerrit), 2016-12-07 01:18:54]

lgtm

[xianglu, 2016-12-07 01:21:57]

xianglu@chromium.org changed reviewers:
+ haraken@chromium.org

[xianglu, 2016-12-07 01:23:50]

haraken@ PTAL.

[haraken, 2016-12-07 01:27:13]

LGTM

[xianglu, 2016-12-07 01:29:43]

The CQ bit was checked by xianglu@chromium.org

[xianglu, 2016-12-07 01:29:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2557513003/#ps240001
(title: "Move tainting logic into detect()")

[commit-bot: I haz the power, 2016-12-07 01:30:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 04:11:05]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1481074183857670,
"parent_rev": "ea00ff7f6d8b4a9557e6dce562235eb68042cccc", "commit_rev":
"bcaf7d826df9938910d429c6862fcc3393808358"}

[commit-bot: I haz the power, 2016-12-07 04:12:09]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

[commit-bot: I haz the power, 2016-12-07 04:12:11]

Committed patchset #5 (id:240001)

[commit-bot: I haz the power, 2016-12-07 04:15:43]

Description was changed from

==========
This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139
==========

to

==========
This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG=646083, 659139

Committed: https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400
Cr-Commit-Position: refs/heads/master@{#436856}
==========

[commit-bot: I haz the power, 2016-12-07 04:15:44]

Patchset 5 (id:??) landed as
https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400
Cr-Commit-Position: refs/heads/master@{#436856}