ui/views/mus/text_input_client_impl.cc - Issue 2557493002: IME for Mus: Use ui::InputMethodChromeOS to provide logic for ime driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/mus/text_input_client_impl.cc

Issue 2557493002: IME for Mus: Use ui::InputMethodChromeOS to provide logic for ime driver. (Closed)

Patch Set: More cleanup. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/mus/text_input_client_impl.cc

diff --git a/ui/views/mus/text_input_client_impl.cc b/ui/views/mus/text_input_client_impl.cc

index 9e5b21621b359579720eeaf1aa22fb1f922207a4..4193e127e280382d4610a27dd6fec609f109ddb8 100644

--- a/ui/views/mus/text_input_client_impl.cc

+++ b/ui/views/mus/text_input_client_impl.cc

@@ -38,9 +38,7 @@ void TextInputClientImpl::InsertText(const std::string& text) {

void TextInputClientImpl::InsertChar(std::unique_ptr<ui::Event> event) {

DCHECK(event->IsKeyEvent());

- ui::KeyEvent* key_event = event->AsKeyEvent();

- DCHECK(key_event->is_char());

sadrul 2016/12/12 18:50:16 Does this DCHECK() no longer hold?

- text_input_client_->InsertChar(*key_event);

+ text_input_client_->InsertChar(*event->AsKeyEvent());

}

} // namespace views