Add blink_perf.paint_spinvalidation and blink_perf.svg_spinvalidation suites

tools/perf/benchmarks/blink_perf.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 from core import path_util
 from core import perf_benchmark
 
 from telemetry import benchmark
@@ skipping 101 matching lines @@
       units = parts[-1]
       metric = page.display_name.split('.')[0].replace('/', '_')
       results.AddValue(list_of_scalar_values.ListOfScalarValues(
           results.current_page, metric, units, values))
 
       break
 
     print log
 
 
+class _BlinkPerfMeasurementSPInvalidation(_BlinkPerfMeasurement):

[pdr., 2016/12/06 06:47:28]

It's really long but WDYT of changing this to:
_BlinkPerfMeasurementSlimmingPaintInvalidation

I think this will help reduce confusion if other people read this code and are
not familiar with our 'SP' names.

[Xianzhu, 2016/12/06 17:23:34]

Done.

+  def CustomizeBrowserOptions(self, options):
+    _BlinkPerfMeasurement.CustomizeBrowserOptions(self, options)
+    options.AppendExtraBrowserArgs([
+        '--enable-blink-features=SlimmingPaintInvalidation'
+    ])
+
+
 class _SharedPywebsocketPageState(shared_page_state.SharedPageState):
   """Runs a pywebsocket server."""
 
   def __init__(self, test, finder_options, user_story_set):
     super(_SharedPywebsocketPageState, self).__init__(
         test, finder_options, user_story_set)
     self.platform.StartLocalServer(pywebsocket_server.PywebsocketServer())
 
 
 @benchmark.Disabled('all') # http://crbug.com/670069
@@ skipping 128 matching lines @@
 
   def CreateStorySet(self, options):
     path = os.path.join(BLINK_PERF_BASE_DIR, 'Paint')
     return CreateStorySetFromPath(path, SKIPPED_FILE)
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     return cls.IsSvelte(possible_browser)  # http://crbug.com/574483
 
 
+class BlinkPerfPaintSPInvalidation(BlinkPerfPaint):

[pdr., 2016/12/06 06:47:28]

Can you add a link to either of the design docs and a note that this can be
removed when slimming-paint-invalidation ships (here and below)?

I think this can be done with a python class comment:
  """The blink_perf.paint_slimmingpaintinvalidation tests measure paint time
  with the new paint invalidation system (see: https://goo.gl/eQczQW). These
  tests should be removed when slimming paint invalidation ships.
  """

[Xianzhu, 2016/12/06 17:23:34]

I put the following doc in _BlinkPerfMeasurementSlimmingPaintInvalidation:

"""Measures blink perf with the new paint invalidation system (see:
https://goo.gl/eQczQW). The benchmarks using this measurement should be
removed when slimming paint invalidation ships."""

+  tag = 'paint_spinvalidation'
+  test = _BlinkPerfMeasurementSPInvalidation
+
+  @classmethod
+  def Name(cls):
+    return 'blink_perf.paint_spinvalidation'
+
+
 @benchmark.Disabled('win')  # crbug.com/488493
 class BlinkPerfParser(perf_benchmark.PerfBenchmark):
   tag = 'parser'
   test = _BlinkPerfMeasurement
 
   @classmethod
   def Name(cls):
     return 'blink_perf.parser'
 
   def CreateStorySet(self, options):
     path = os.path.join(BLINK_PERF_BASE_DIR, 'Parser')
     return CreateStorySetFromPath(path, SKIPPED_FILE)
 
 
 class BlinkPerfSVG(perf_benchmark.PerfBenchmark):
   tag = 'svg'
   test = _BlinkPerfMeasurement
 
   @classmethod
   def Name(cls):
     return 'blink_perf.svg'
 
   def CreateStorySet(self, options):
     path = os.path.join(BLINK_PERF_BASE_DIR, 'SVG')
     return CreateStorySetFromPath(path, SKIPPED_FILE)
 
 
+class BlinkPerfSVGSPInvalidation(BlinkPerfSVG):
+  tag = 'svg_spinvalidation'
+  test = _BlinkPerfMeasurementSPInvalidation
+
+  @classmethod
+  def Name(cls):
+    return 'blink_perf.svg_spinvalidation'
+
+
 class BlinkPerfShadowDOM(perf_benchmark.PerfBenchmark):
   tag = 'shadow_dom'
   test = _BlinkPerfMeasurement
 
   @classmethod
   def Name(cls):
     return 'blink_perf.shadow_dom'
 
   def CreateStorySet(self, options):
     path = os.path.join(BLINK_PERF_BASE_DIR, 'ShadowDOM')
@@ skipping 34 matching lines @@
 
   def CreateStorySet(self, options):
     path = os.path.join(BLINK_PERF_BASE_DIR, 'Pywebsocket')
     return CreateStorySetFromPath(
         path, SKIPPED_FILE,
         shared_page_state_class=_SharedPywebsocketPageState)
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     return cls.IsSvelte(possible_browser)  # http://crbug.com/551950