Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: src/counters.cc

Issue 2557463003: [Tracing] Remove AppendLongInteger in TracedValue. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/tracing/traced-value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/counters.cc
diff --git a/src/counters.cc b/src/counters.cc
index 911cc3d2391f544198c833d736e1cf3943031051..df4ea0086031a9b5be1c4f06bdd020d52ae5e07e 100644
--- a/src/counters.cc
+++ b/src/counters.cc
@@ -280,8 +280,8 @@ void RuntimeCallCounter::Reset() {
void RuntimeCallCounter::Dump(v8::tracing::TracedValue* value) {
value->BeginArray(name_);
- value->AppendLongInteger(count_);
- value->AppendLongInteger(time_.InMicroseconds());
+ value->AppendString(std::to_string(count_));
+ value->AppendString(std::to_string(time_.InMicroseconds()));
alph 2016/12/06 00:54:42 I think it's better to use double for both. 2^52 u
lpy 2016/12/06 01:45:49 Done.
value->EndArray();
}
« no previous file with comments | « no previous file | src/tracing/traced-value.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698