[Tracing] Remove AppendLongInteger in TracedValue.

[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org

Committed: https://crrev.com/900d1982cd11bb45ef06d9bbf376ca16bc495f08
Cr-Commit-Position: refs/heads/master@{#41533}

[lpy, 2016-12-06 00:37:47]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 00:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-12-06 00:39:00]

lpy@chromium.org changed reviewers:
+ alph@chromium.org, cbruni@chromium.org, fmeawad@chromium.org

[lpy, 2016-12-06 00:39:00]

ptal

[fmeawad, 2016-12-06 00:50:04]

lgtm

[alph, 2016-12-06 00:54:42]

https://codereview.chromium.org/2557463003/diff/1/src/counters.cc
File src/counters.cc (right):

https://codereview.chromium.org/2557463003/diff/1/src/counters.cc#newcode284
src/counters.cc:284:
value->AppendString(std::to_string(time_.InMicroseconds()));
I think it's better to use double for both. 2^52 usec corresponds to 142 years
of uptime.

As a bonus you won't need to update the consumer part.

[commit-bot: I haz the power, 2016-12-06 01:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:09:30]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-12-06 01:45:42]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2016-12-06 01:45:49]

Thanks, ptal.

https://codereview.chromium.org/2557463003/diff/1/src/counters.cc
File src/counters.cc (right):

https://codereview.chromium.org/2557463003/diff/1/src/counters.cc#newcode284
src/counters.cc:284:
value->AppendString(std::to_string(time_.InMicroseconds()));
On 2016/12/06 00:54:42, alph wrote:
> I think it's better to use double for both. 2^52 usec corresponds to 142 years
> of uptime.
> 
> As a bonus you won't need to update the consumer part.

Done.

[commit-bot: I haz the power, 2016-12-06 01:45:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-12-06 02:07:10]

lgtm

[commit-bot: I haz the power, 2016-12-06 02:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:17:07]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-12-06 18:10:00]

Description was changed from

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.
==========

to

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org
==========

[lpy, 2016-12-06 18:10:08]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-12-06 18:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2557463003/#ps20001
(title: "Address alph's comment")

[commit-bot: I haz the power, 2016-12-06 18:10:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 18:12:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481047808558620,
"parent_rev": "0053d37bc4d26908e7402ddc622d948477cbfdaf", "commit_rev":
"a3f0e3f17c174e4574f70fc7989b44c5442691a2"}

[commit-bot: I haz the power, 2016-12-06 18:12:19]

Description was changed from

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org
==========

to

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org
==========

[commit-bot: I haz the power, 2016-12-06 18:12:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 18:12:39]

Description was changed from

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org
==========

to

==========
[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org

Committed: https://crrev.com/900d1982cd11bb45ef06d9bbf376ca16bc495f08
Cr-Commit-Position: refs/heads/master@{#41533}
==========

[commit-bot: I haz the power, 2016-12-06 18:12:40]

Patchset 2 (id:??) landed as
https://crrev.com/900d1982cd11bb45ef06d9bbf376ca16bc495f08
Cr-Commit-Position: refs/heads/master@{#41533}