Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2557463002: Remove left over TODO about builder.ToConstraintSpace.ToLogicalConstraintSpace (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
cbiesinger
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove left over TODO about builder.ToConstraintSpace.ToLogicalConstraintSpace Committed: https://crrev.com/0838fd7a8b580965f9915337cb5ef043b91bb590 Cr-Commit-Position: refs/heads/master@{#436377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Gleb Lanbin
4 years ago (2016-12-05 17:47:37 UTC) #3
cbiesinger
lgtm
4 years ago (2016-12-05 17:48:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557463002/1
4 years ago (2016-12-05 19:46:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 19:54:21 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 19:56:09 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0838fd7a8b580965f9915337cb5ef043b91bb590
Cr-Commit-Position: refs/heads/master@{#436377}

Powered by Google App Engine
This is Rietveld 408576698