Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2557443002: [Blink>Fullscreen] Add UseCounter for fullscreen on orientation change (Closed)
Patch Set: switched to UseCounter Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index ff1331bd4cadc423dc311e1626746ce7ce733867..2e9a98908e780fd3be35a8316b4e0f78e1905bb2 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -87,8 +87,10 @@ bool allowedToRequestFullscreen(Document& document) {
return true;
// The algorithm is triggered by a user generated orientation change.
- if (ScopedOrientationChangeIndicator::processingOrientationChange())
+ if (ScopedOrientationChangeIndicator::processingOrientationChange()) {
+ UseCounter::count(document(), UseCounter::FullscreenOnOrientationChange);
foolip 2016/12/07 08:58:32 Does this actually compile? Should be just documen
foolip 2016/12/07 08:58:32 Suggest FullscreenAllowedByOrientationChange, sinc
Zhiqiang Zhang (Slow) 2016/12/07 11:49:58 Done.
Zhiqiang Zhang (Slow) 2016/12/07 11:49:58 Done.
return true;
+ }
String message = ExceptionMessages::failedToExecute(
"requestFullscreen", "Element",
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698