[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223
Committed: https://crrev.com/12268f9ed6ab22159f1b22ba9af1a6a5ec3faec0
Cr-Commit-Position: refs/heads/master@{#436935}

[Zhiqiang Zhang (Slow), 2016-12-05 18:04:45]

Description was changed from

==========
[Blink>Fullscreen] Record fullscreen request results

This CL adds use counters for recording fullscreen request results and the
corresponding reasons. Currently we record counts that:

* Fullscreen request is allowed from a normal user gesture.
* Fullscreen request is allowed from an orientation change.
* Blocked.

BUG=671223
==========

to

==========
[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223
==========

[Zhiqiang Zhang (Slow), 2016-12-05 18:21:29]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-05 18:21:30]

+mlamouri for an initial local review

[mlamouri (slow - plz ping), 2016-12-05 22:29:36]

lgtm

[Zhiqiang Zhang (Slow), 2016-12-06 10:57:03]

+foolip: third_party/WebKit/ (plus the question on crbug)
+holte: histograms.xml

[Zhiqiang Zhang (Slow), 2016-12-06 10:58:13]

zqzhang@chromium.org changed reviewers:
+ foolip@chromium.org, holte@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-06 10:58:13]

+foolip: third_party/WebKit/ (plus the question on crbug)
+holte: histograms.xml

[Steven Holte, 2016-12-06 19:38:03]

histograms lgtm

[foolip, 2016-12-07 08:58:32]

lgtm % nits

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Fullscreen.cpp (right):

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:91:
UseCounter::count(document(), UseCounter::FullscreenOnOrientationChange);
Does this actually compile? Should be just document.

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:91:
UseCounter::count(document(), UseCounter::FullscreenOnOrientationChange);
Suggest FullscreenAllowedByOrientationChange, since there could still be other
things that make it go wrong.

[Zhiqiang Zhang (Slow), 2016-12-07 11:49:58]

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Fullscreen.cpp (right):

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:91:
UseCounter::count(document(), UseCounter::FullscreenOnOrientationChange);
On 2016/12/07 08:58:32, foolip wrote:
> Does this actually compile? Should be just document.

Done.

https://codereview.chromium.org/2557443002/diff/10003/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:91:
UseCounter::count(document(), UseCounter::FullscreenOnOrientationChange);
On 2016/12/07 08:58:32, foolip wrote:
> Suggest FullscreenAllowedByOrientationChange, since there could still be other
> things that make it go wrong.

Done.

[Zhiqiang Zhang (Slow), 2016-12-07 11:50:09]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-07 11:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
holte@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2557443002/#ps30001
(title: "nits")

[commit-bot: I haz the power, 2016-12-07 11:50:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 13:51:23]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1481111409601760,
"parent_rev": "b7aa51d57664d525d5ff25db151435c8ba44acc4", "commit_rev":
"50c7d55ca9685deca55c991c60a7599f66e23727"}

[commit-bot: I haz the power, 2016-12-07 13:52:03]

Description was changed from

==========
[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223
==========

to

==========
[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223
==========

[commit-bot: I haz the power, 2016-12-07 13:52:04]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-12-07 13:55:01]

Description was changed from

==========
[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223
==========

to

==========
[Blink>Fullscreen] Add UseCounter for fullscreen on orientation change

This CL adds UseCounter to record the number of requests for
fullscreen on device orientation change.

BUG=671223

Committed: https://crrev.com/12268f9ed6ab22159f1b22ba9af1a6a5ec3faec0
Cr-Commit-Position: refs/heads/master@{#436935}
==========

[commit-bot: I haz the power, 2016-12-07 13:55:02]

Patchset 3 (id:??) landed as
https://crrev.com/12268f9ed6ab22159f1b22ba9af1a6a5ec3faec0
Cr-Commit-Position: refs/heads/master@{#436935}