Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: content/browser/loader/intercepting_resource_handler_unittest.cc

Issue 2557433005: Revert of Fix a pair of ResourceLoader cancellation/error bugs. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/resource_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/intercepting_resource_handler_unittest.cc
diff --git a/content/browser/loader/intercepting_resource_handler_unittest.cc b/content/browser/loader/intercepting_resource_handler_unittest.cc
index 87ba506334844dd910b3549812e32a2b0545b694..9f2096ce76cc344fa15b98a40c0544d459a2b1a0 100644
--- a/content/browser/loader/intercepting_resource_handler_unittest.cc
+++ b/content/browser/loader/intercepting_resource_handler_unittest.cc
@@ -233,11 +233,6 @@
std::string old_handler_body;
std::unique_ptr<TestResourceHandler> old_handler_scoped(
new TestResourceHandler(&old_handler_status, &old_handler_body));
- // When sending a payload to the old ResourceHandler, the
- // InterceptingResourceHandler doesn't send a final EOF read.
- // TODO(mmenke): Should it? Or can we just get rid of that 0-byte read
- // entirely?
- old_handler_scoped->set_expect_eof_read(false);
TestResourceHandler* old_handler = old_handler_scoped.get();
scoped_refptr<net::IOBuffer> old_buffer = old_handler->buffer();
std::unique_ptr<InterceptingResourceHandler> intercepting_handler(
@@ -605,11 +600,6 @@
std::string old_handler_body;
std::unique_ptr<TestResourceHandler> old_handler(
new TestResourceHandler(&old_handler_status, &old_handler_body));
- // When sending a payload to the old ResourceHandler, the
- // InterceptingResourceHandler doesn't send a final EOF read.
- // TODO(mmenke): Should it? Or can we just get rid of that 0-byte read
- // entirely?
- old_handler->set_expect_eof_read(false);
old_handler->SetBufferSize(10);
old_handler->set_defer_on_read_completed(true);
@@ -697,10 +687,6 @@
EXPECT_EQ(old_handler_status.status(), net::URLRequestStatus::SUCCESS);
EXPECT_EQ(new_handler_status.status(), net::URLRequestStatus::IO_PENDING);
- // Final EOF byte is read.
- ASSERT_TRUE(intercepting_handler->OnReadCompleted(0, &defer));
- ASSERT_FALSE(defer);
-
defer = false;
intercepting_handler->OnResponseCompleted({net::URLRequestStatus::SUCCESS, 0},
&defer);
@@ -774,11 +760,6 @@
std::string old_handler_body;
std::unique_ptr<TestResourceHandler> old_handler(
new TestResourceHandler(&old_handler_status, &old_handler_body));
- // When sending a payload to the old ResourceHandler, the
- // InterceptingResourceHandler doesn't send a final EOF read.
- // TODO(mmenke): Should it? Or can we just get rid of that 0-byte read
- // entirely?
- old_handler->set_expect_eof_read(false);
std::unique_ptr<InterceptingResourceHandler> intercepting_handler(
new InterceptingResourceHandler(std::move(old_handler), request.get()));
« no previous file with comments | « no previous file | content/browser/loader/resource_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698