Chromium Code Reviews
DescriptionRevert of Fix a pair of ResourceLoader cancellation/error bugs. (patchset #7 id:120001 of https://codereview.chromium.org/2543633004/ )
Reason for revert:
Preemptively reverting because this seems to be the most likely cause of these webkit_tests crashing:
http/tests/serviceworker/registration.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/register-link-element.html
http/tests/serviceworker/chromium/register-error-messages.html
virtual/mojo-loading/http/tests/serviceworker/register-link-element.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/registration.html
virtual/service-worker-navigation-preload/http/tests/serviceworker/register-link-element.html
virtual/service-worker-navigation-preload/http/tests/serviceworker/registration.html
http/tests/serviceworker/register-link-element.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/chromium/register-error-messages.html
virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/register-error-messages.html
virtual/mojo-loading/http/tests/serviceworker/chromium/register-error-messages.html
virtual/mojo-loading/http/tests/serviceworker/registration.html
If this is not the actual root I'll re-revert it back.
Original issue's description:
> Fix a pair of ResourceLoader cancellation/error bugs.
>
> Both of these would result in two completion messages being passed
> down the ResourceHandler chain.
>
> Also add a bunch of tests of various flows through ResourceLoader, one
> of which is disabled due to yet another bug (Which I'll fix in another
> CL), and make the ResourceLoader tests use the same TestResourceHandler
> that the MIME sniffing / intercepting ResourceHandler tests use.
>
> BUG=669709
>
> Committed: https://crrev.com/1d5e2e389193fc814291e64469a9b28d3412a9e9
> Cr-Commit-Position: refs/heads/master@{#436732}
TBR=rdsmith@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=669709
Committed: https://crrev.com/ab650bf37d14c76a794fe42f7cd0739dc01b752a
Cr-Commit-Position: refs/heads/master@{#436769}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||