Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2557433005: Revert of Fix a pair of ResourceLoader cancellation/error bugs. (Closed)

Created:
4 years ago by carlosk
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a pair of ResourceLoader cancellation/error bugs. (patchset #7 id:120001 of https://codereview.chromium.org/2543633004/ ) Reason for revert: Preemptively reverting because this seems to be the most likely cause of these webkit_tests crashing: http/tests/serviceworker/registration.html virtual/disable-mojo-service-worker/http/tests/serviceworker/register-link-element.html http/tests/serviceworker/chromium/register-error-messages.html virtual/mojo-loading/http/tests/serviceworker/register-link-element.html virtual/disable-mojo-service-worker/http/tests/serviceworker/registration.html virtual/service-worker-navigation-preload/http/tests/serviceworker/register-link-element.html virtual/service-worker-navigation-preload/http/tests/serviceworker/registration.html http/tests/serviceworker/register-link-element.html virtual/disable-mojo-service-worker/http/tests/serviceworker/chromium/register-error-messages.html virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/register-error-messages.html virtual/mojo-loading/http/tests/serviceworker/chromium/register-error-messages.html virtual/mojo-loading/http/tests/serviceworker/registration.html If this is not the actual root I'll re-revert it back. Original issue's description: > Fix a pair of ResourceLoader cancellation/error bugs. > > Both of these would result in two completion messages being passed > down the ResourceHandler chain. > > Also add a bunch of tests of various flows through ResourceLoader, one > of which is disabled due to yet another bug (Which I'll fix in another > CL), and make the ResourceLoader tests use the same TestResourceHandler > that the MIME sniffing / intercepting ResourceHandler tests use. > > BUG=669709 > > Committed: https://crrev.com/1d5e2e389193fc814291e64469a9b28d3412a9e9 > Cr-Commit-Position: refs/heads/master@{#436732} TBR=rdsmith@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669709 Committed: https://crrev.com/ab650bf37d14c76a794fe42f7cd0739dc01b752a Cr-Commit-Position: refs/heads/master@{#436769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -779 lines) Patch
M content/browser/loader/intercepting_resource_handler_unittest.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 25 chunks +267 lines, -545 lines 0 comments Download
M content/browser/loader/test_resource_handler.h View 6 chunks +6 lines, -85 lines 0 comments Download
M content/browser/loader/test_resource_handler.cc View 4 chunks +13 lines, -98 lines 0 comments Download
M net/url_request/url_request_test_job.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
carlosk
Created Revert of Fix a pair of ResourceLoader cancellation/error bugs.
4 years ago (2016-12-06 23:15:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557433005/1
4 years ago (2016-12-06 23:16:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 23:17:41 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 23:19:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab650bf37d14c76a794fe42f7cd0739dc01b752a
Cr-Commit-Position: refs/heads/master@{#436769}

Powered by Google App Engine
This is Rietveld 408576698