Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: appengine/findit/crash/test/changelist_classifier_test.py

Issue 2557423003: Making Stacktrace immutable, so it can be hashable (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/stacktrace.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/changelist_classifier_test.py
diff --git a/appengine/findit/crash/test/changelist_classifier_test.py b/appengine/findit/crash/test/changelist_classifier_test.py
index ee802af61d228d0df83f9a719770d4c94eff2295..0caca65372c28d865aca2ce2f155b69cc736e199 100644
--- a/appengine/findit/crash/test/changelist_classifier_test.py
+++ b/appengine/findit/crash/test/changelist_classifier_test.py
@@ -107,6 +107,9 @@ DUMMY_CHANGELOG3 = ChangeLog.FromDict({
# CrashReport directly and pulls out the revision_range and platform
# itself; that way ChangelistClassifier.__call__ needn't worry about it,
# allowing us to clean up the tests here.
+# TODO(wrengr): this empty stacktrace causes the unittests to emit
+# logging warnings about the fact that we can't get the crash_stack. Would
+# be nice to avoid that.
DUMMY_REPORT = CrashReport(None, None, None, Stacktrace(), (None, None))
class ChangelistClassifierTest(CrashTestSuite):
« no previous file with comments | « appengine/findit/crash/stacktrace.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698