appengine/findit/crash/crash_report.py - Issue 2557423003: Making Stacktrace immutable, so it can be hashable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/crash_report.py

Issue 2557423003: Making Stacktrace immutable, so it can be hashable (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/crash_report.py

diff --git a/appengine/findit/crash/crash_report.py b/appengine/findit/crash/crash_report.py

index db622caeaeb35c13d8a94f16a5263f68a3305551..d9ccec0d47517f8fd6b9a1cde82a0c94e7a572ea 100644

--- a/appengine/findit/crash/crash_report.py

+++ b/appengine/findit/crash/crash_report.py

@@ -35,8 +35,7 @@ class CrashReport(namedtuple('CrashReport',

def __new__(cls, crashed_version, signature, platform, stacktrace,

regression_range):

- # TODO: should raise a TypeError rather than an AssertionError

- assert isinstance(stacktrace, Stacktrace), (

+ assert isinstance(stacktrace, Stacktrace), TypeError(

'In the fourth argument to CrashReport constructor, '

'expected Stacktrace object, but got %s object instead.'

% stacktrace.__class__.__name__)

« no previous file with comments | « no previous file | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »