Android perf tests: kill adbd on the device after running a test.

build/android/pylib/android_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 """
 
 import collections
@@ skipping 441 matching lines @@
         # Force a hard reboot on last attempt
         self.Reboot(full_reboot=(reboots_left == 1))
         reboots_left -= 1
 
   def MakeSystemFolderWritable(self):
     """Remounts the /system folder rw."""
     out = self._adb.SendCommand('remount')
     if out.strip() != 'remount succeeded':
       raise errors.MsgException('Remount failed: %s' % out)
 
+  def KillAdbdDevice(self):
+    try:
+      logging.info('Killing adbd on the device...')
+      adb_pids = self.ExtractPid('adbd')
+      if adb_pids:
+        self.RunShellCommandWithSU('kill %s' % ' '.join(adb_pids))
+      logging.info('Waiting for device to settle...')
+      time.sleep(5)
+    except Exception as e:

[craigdh, 2013/10/02 17:36:53]

Let's not eat the exception here. It's fine if you want to catch and ignore it
in the perf test but in general I think we should allow exceptions to bubble up
from android_commands to avoid silent failures.

[bulach, 2013/10/03 08:26:13]

good point! agreed, moved the try..except up to the perf test..

+      logging.error('Exception when killing adbd %s', e)
+
   def RestartAdbServer(self):
     """Restart the adb server."""
     ret = self.KillAdbServer()
     if ret != 0:
       raise errors.MsgException('KillAdbServer: %d' % ret)
 
     ret = self.StartAdbServer()
     if ret != 0:
       raise errors.MsgException('StartAdbServer: %d' % ret)
 
@@ skipping 1106 matching lines @@
   """
   def __init__(self, output):
     self._output = output
 
   def write(self, data):
     data = data.replace('\r\r\n', '\n')
     self._output.write(data)
 
   def flush(self):
     self._output.flush()