Android perf tests: kill adbd on the device after running a test.

build/android/pylib/perf/test_runner.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs a perf test on a single device.
 
 Our buildbot infrastructure requires each slave to run steps serially.
 This is sub-optimal for android, where these steps can run independently on
 multiple connected devices.
 
@@ skipping 38 matching lines @@
   --keep_test_server_ports: indicates it's being run as a shard, and shouldn't
   reset test server port allocation.
 """
 
 import datetime
 import logging
 import pexpect
 import pickle
 import os
 import sys
+import time
 
+from pylib import android_commands
 from pylib import constants
 from pylib.base import base_test_result
 from pylib.base import base_test_runner
 
 
 def PrintTestOutput(test_name):
   """Helper method to print the output of previously executed test_name.
 
   Args:
     test_name: name of the test that has been previously executed.
@@ skipping 80 matching lines @@
         'name': test_name,
         'output': output,
         'exit_code': exit_code,
         'result_type': result_type,
         'total_time': (end_time - start_time).seconds,
         'device': self.device,
         'cmd': cmd,
     }
     self._SaveResult(persisted_result)
 
+
+    try:
+      logging.info('Killing adbd on the device...')
+      adb = android_commands.AndroidCommands(self.device)

[craigdh, 2013/10/01 18:56:44]

An adb object should already exists for this device. Normally that is reused
instead of creating a new one.

[navabi, 2013/10/01 22:55:10]

I don't understand. Where is the reference to that adb object? We do not have a
reference to an adb object here. Are you suggesting it be passed in to
TestRunner?

[bulach, 2013/10/02 08:53:43]

I think base_test_runner.BaseTestRunner has already an adb member available,
using that instead.

+      adb_pids = adb.ExtractPid('adbd')
+      if adb_pids:
+        adb.RunShellCommandWithSU('kill %s' % ' '.join(adb_pids))

[craigdh, 2013/10/01 18:56:44]

Instead of putting all this here, let's add
android_commands.AndroidCommands.KillAdbd()

[navabi, 2013/10/01 22:55:10]

+1

[bulach, 2013/10/02 08:53:43]

Done.

+      logging.info('Waiting for device to settle...')
+      time.sleep(5)
+    except Exception as e:
+      logging.error('Exception when killing adbd %s', e)
+
     return (output, result_type)
 
   def RunTest(self, test_name):
     """Run a perf test on the device.
 
     Args:
       test_name: String to use for logging the test result.
 
     Returns:
       A tuple of (TestRunResults, retry).
     """
     output, result_type = self._LaunchPerfTest(test_name)
     results = base_test_result.TestRunResults()
     results.AddResult(base_test_result.BaseTestResult(test_name, result_type))
     retry = None
     if not results.DidRunPass():
       retry = test_name
     return results, retry