chrome/browser/ntp_snippets/content_suggestions_service_factory.cc - Issue 2557363002: [NTP Snippets] Refactor background scheduling for remote suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2557363002: [NTP Snippets] Refactor background scheduling for remote suggestions (Closed)

Patch Set: Make unit-tests pass Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/ntp/ntp_snippets_bridge.cc ('K') | « chrome/browser/android/ntp/ntp_snippets_launcher.h ('k') | chrome/browser/ui/webui/snippets_internals_message_handler.h » ('j') | components/ntp_snippets/remote/remote_suggestions_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

index 90fd846817098499f419ad3e8389e4c467aa01d6..0f263a503bff5b5bed483e388205862e221171d7 100644

--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

@@ -34,8 +34,8 @@

#include "components/ntp_snippets/features.h"

#include "components/ntp_snippets/ntp_snippets_constants.h"

#include "components/ntp_snippets/remote/ntp_snippets_fetcher.h"

-#include "components/ntp_snippets/remote/ntp_snippets_scheduler.h"

#include "components/ntp_snippets/remote/remote_suggestions_database.h"

+#include "components/ntp_snippets/remote/remote_suggestions_hard_scheduler.h"

#include "components/ntp_snippets/remote/remote_suggestions_provider.h"

#include "components/ntp_snippets/remote/remote_suggestions_status_service.h"

#include "components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h"

@@ -79,8 +79,8 @@ using ntp_snippets::CategoryFactory;

using ntp_snippets::ContentSuggestionsService;

using ntp_snippets::ForeignSessionsSuggestionsProvider;

using ntp_snippets::NTPSnippetsFetcher;

-using ntp_snippets::NTPSnippetsScheduler;

using ntp_snippets::RemoteSuggestionsDatabase;

+using ntp_snippets::RemoteSuggestionsHardScheduler;

using ntp_snippets::RemoteSuggestionsProvider;

using ntp_snippets::RemoteSuggestionsStatusService;

using ntp_snippets::TabDelegateSyncAdapter;

@@ -152,7 +152,7 @@ void RegisterArticleProvider(SigninManagerBase* signin_manager,

content::BrowserContext::GetDefaultStoragePartition(profile)

->GetURLRequestContext();

- NTPSnippetsScheduler* scheduler = nullptr;

+ RemoteSuggestionsHardScheduler* scheduler = nullptr;

#if defined(OS_ANDROID)

scheduler = NTPSnippetsLauncher::Get();

#endif // OS_ANDROID

@@ -181,7 +181,7 @@ void RegisterArticleProvider(SigninManagerBase* signin_manager,

base::MakeUnique<RemoteSuggestionsDatabase>(database_dir, task_runner),

base::MakeUnique<RemoteSuggestionsStatusService>(signin_manager,

pref_service));

- service->set_ntp_snippets_service(provider.get());

+ service->set_remote_suggestions_provider(provider.get());

service->RegisterProvider(std::move(provider));

}