components/ntp_snippets/BUILD.gn - Issue 2557363002: [NTP Snippets] Refactor background scheduling for remote suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 2557363002: [NTP Snippets] Refactor background scheduling for remote suggestions (Closed)

Patch Set: Tim's comments and splitting RemoteSuggestionsProvider and RemoteSuggestionsProviderImpl Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/content_suggestions_provider.h » ('j') | components/ntp_snippets/content_suggestions_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/BUILD.gn

diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn

index 8d68dfb31dbac2ef2e0f015414d0a4ac13c01839..613939abe8e4f8e07952962094d4fbf1a4391ba8 100644

--- a/components/ntp_snippets/BUILD.gn

+++ b/components/ntp_snippets/BUILD.gn

@@ -48,15 +48,20 @@ static_library("ntp_snippets") {

"remote/ntp_snippet.h",

"remote/ntp_snippets_fetcher.cc",

"remote/ntp_snippets_fetcher.h",

- "remote/ntp_snippets_scheduler.h",

+ "remote/persistent_scheduler.h",

"remote/remote_suggestions_database.cc",

"remote/remote_suggestions_database.h",

"remote/remote_suggestions_provider.cc",

"remote/remote_suggestions_provider.h",

+ "remote/remote_suggestions_provider_impl.cc",

+ "remote/remote_suggestions_provider_impl.h",

+ "remote/remote_suggestions_scheduler.h",

"remote/remote_suggestions_status_service.cc",

"remote/remote_suggestions_status_service.h",

"remote/request_throttler.cc",

"remote/request_throttler.h",

+ "remote/scheduling_remote_suggestions_provider.cc",

+ "remote/scheduling_remote_suggestions_provider.h",

"sessions/foreign_sessions_suggestions_provider.cc",

"sessions/foreign_sessions_suggestions_provider.h",

"sessions/tab_delegate_sync_adapter.cc",

@@ -123,9 +128,10 @@ source_set("unit_tests") {

"remote/ntp_snippet_unittest.cc",

"remote/ntp_snippets_fetcher_unittest.cc",

"remote/remote_suggestions_database_unittest.cc",

- "remote/remote_suggestions_provider_unittest.cc",

+ "remote/remote_suggestions_provider_impl_unittest.cc",

"remote/remote_suggestions_status_service_unittest.cc",

"remote/request_throttler_unittest.cc",

+ "remote/scheduling_remote_suggestions_provider_unittest.cc",

"remote/test_utils.cc",

"remote/test_utils.h",

"sessions/foreign_sessions_suggestions_provider_unittest.cc",