[NTP Snippets] Refactor background scheduling for remote suggestions

chrome/browser/android/ntp/ntp_snippets_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h"
 
 #include <jni.h>
 #include <utility>
 #include <vector>
 
@@ skipping 84 matching lines @@
 }
 
 ntp_snippets::RemoteSuggestionsProvider* GetRemoteSuggestionsProvider() {
   ntp_snippets::ContentSuggestionsService* content_suggestions_service =
       ContentSuggestionsServiceFactory::GetForProfile(
           ProfileManager::GetLastUsedProfile());
   // Can maybe be null in some cases? (Incognito profile?) crbug.com/647920
   if (!content_suggestions_service) {
     return nullptr;
   }
-  return content_suggestions_service->ntp_snippets_service();
+  return content_suggestions_service->remote_suggestions_provider();
 }
 
 }  // namespace
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& obj,
                   const JavaParamRef<jobject>& j_profile) {
   NTPSnippetsBridge* snippets_bridge = new NTPSnippetsBridge(env, j_profile);
   return reinterpret_cast<intptr_t>(snippets_bridge);
 }
 
 static void FetchRemoteSuggestions(JNIEnv* env,
                                    const JavaParamRef<jclass>& caller) {
   ntp_snippets::RemoteSuggestionsProvider* remote_suggestions_provider =
       GetRemoteSuggestionsProvider();
   // Can be null if the feature has been disabled but the scheduler has not been
   // unregistered yet. The next start should unregister it.
   if (!remote_suggestions_provider) {
     return;
   }
+
   remote_suggestions_provider->FetchSnippetsForAllCategories();
 }
 
 static void FetchRemoteSuggestionsInTheBackground(
     JNIEnv* env,
     const JavaParamRef<jclass>& caller) {
   ntp_snippets::RemoteSuggestionsProvider* remote_suggestions_provider =
       GetRemoteSuggestionsProvider();
   // Can be null if the feature has been disabled but the scheduler has not been
   // unregistered yet. The next start should unregister it.
   if (!remote_suggestions_provider) {
     return;
   }
-  remote_suggestions_provider->FetchSnippetsInTheBackground();
+
+  remote_suggestions_provider->scheduler()->PerformHardUpdate();

[tschumann, 2016/12/09 17:27:28]

this is a smell. If this is a funtionality this provider supports, then  the
RemoteSuggestionsProvider should have get a method to support this and not
reveal implementation details like the scheduler.

[jkrcal, 2016/12/14 09:42:09]

Done.

 }
 
 // Reschedules the fetching of snippets. If tasks are already scheduled, they
 // will be rescheduled anyway, so all running intervals will be reset.
 static void RescheduleFetching(JNIEnv* env,
                                const JavaParamRef<jclass>& caller) {
-  Profile* profile = ProfileManager::GetLastUsedProfile();
-  // Temporary check while investigating crbug.com/647920.
-  CHECK(profile);
-
-  ntp_snippets::ContentSuggestionsService* content_suggestions_service =
-      ContentSuggestionsServiceFactory::GetForProfile(profile);
-
-  // Can maybe be null in some cases? (Incognito profile?) crbug.com/647920
-  if (!content_suggestions_service) {
+  ntp_snippets::RemoteSuggestionsProvider* remote_suggestions_provider =
+      GetRemoteSuggestionsProvider();
+  // Can be null if the feature has been disabled but the scheduler has not been
+  // unregistered yet. The next start should unregister it.
+  if (!remote_suggestions_provider) {
     return;
   }
 
-  ntp_snippets::RemoteSuggestionsProvider* service =
-      content_suggestions_service->ntp_snippets_service();
-
-  // Can be null if the feature has been disabled but the scheduler has not been
-  // unregistered yet. The next start should unregister it.
-  if (!service) {
-    return;
-  }
-
-  service->RescheduleFetching(/*force=*/true);
+  remote_suggestions_provider->scheduler()->Unschedule();

[tschumann, 2016/12/09 17:27:28]

same here: just add a single Reschedule() function on the provider itself and
don't expose the scheduler.

[jkrcal, 2016/12/14 09:42:09]

Done.

+  remote_suggestions_provider->scheduler()->Schedule();
 }
 
 static void OnSuggestionTargetVisited(JNIEnv* env,
                                       const JavaParamRef<jclass>& caller,
                                       jint j_category_id,
                                       jlong visit_time_ms) {
   Profile* profile = ProfileManager::GetLastUsedProfile();
   ntp_snippets::ContentSuggestionsService* content_suggestions_service =
       ContentSuggestionsServiceFactory::GetForProfile(profile);
   ntp_snippets::metrics::OnSuggestionTargetVisited(
@@ skipping 298 matching lines @@
 }
 
 Category NTPSnippetsBridge::CategoryFromIDValue(jint id) {
   return content_suggestions_service_->category_factory()->FromIDValue(id);
 }
 
 // static
 bool NTPSnippetsBridge::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }