[NTP Snippets] Refactor background scheduling for remote suggestions

chrome/browser/ui/webui/snippets_internals_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 62 matching lines @@
       return "LOADING_ERROR";
   }
   return std::string();
 }
 
 }  // namespace
 
 SnippetsInternalsMessageHandler::SnippetsInternalsMessageHandler()
     : content_suggestions_service_observer_(this),
       dom_loaded_(false),
-      ntp_snippets_service_(nullptr),
+      remote_suggestions_provider_(nullptr),
       content_suggestions_service_(nullptr),
       weak_ptr_factory_(this) {}
 
 SnippetsInternalsMessageHandler::~SnippetsInternalsMessageHandler() {}
 
 void SnippetsInternalsMessageHandler::RegisterMessages() {
   // Additional initialization (web_ui() does not work from the constructor).
   Profile* profile = Profile::FromWebUI(web_ui());
 
   content_suggestions_service_ =
       ContentSuggestionsServiceFactory::GetInstance()->GetForProfile(profile);
   content_suggestions_service_observer_.Add(content_suggestions_service_);
 
-  ntp_snippets_service_ = content_suggestions_service_->ntp_snippets_service();
+  remote_suggestions_provider_ =
+      content_suggestions_service_->remote_suggestions_provider();
 
   web_ui()->RegisterMessageCallback(
       "refreshContent",
       base::Bind(&SnippetsInternalsMessageHandler::HandleRefreshContent,
                  base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback(
       "download", base::Bind(&SnippetsInternalsMessageHandler::HandleDownload,
                              base::Unretained(this)));
 
@@ skipping 71 matching lines @@
 
   SendAllContent();
 }
 
 void SnippetsInternalsMessageHandler::HandleDownload(
     const base::ListValue* args) {
   DCHECK_EQ(1u, args->GetSize());
 
   SendString("hosts-status", std::string());
 
-  if (!ntp_snippets_service_)
+  if (!remote_suggestions_provider_)
     return;
 
   std::string hosts_string;
   if (!args->GetString(0, &hosts_string))
     return;
 
   std::vector<std::string> hosts_vector = base::SplitString(
       hosts_string, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
   std::set<std::string> hosts(hosts_vector.begin(), hosts_vector.end());
 
-  ntp_snippets_service_->FetchSnippetsFromHosts(hosts,
+  remote_suggestions_provider_->FetchSnippetsFromHosts(hosts,
                                                 /*interactive_request=*/true);
 }
 
 void SnippetsInternalsMessageHandler::HandleClearCachedSuggestions(
     const base::ListValue* args) {
   DCHECK_EQ(1u, args->GetSize());
 
   int category_id;
   if (!args->GetInteger(0, &category_id))
     return;
@@ skipping 78 matching lines @@
   SendBoolean(
       "flag-bookmark-suggestions",
       base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature));
 
   SendBoolean("flag-physical-web-page-suggestions",
               base::FeatureList::IsEnabled(
                   ntp_snippets::kPhysicalWebPageSuggestionsFeature));
 
   SendClassification();
 
-  if (ntp_snippets_service_) {
-    switch (ntp_snippets_service_->snippets_fetcher()->personalization()) {
+  if (remote_suggestions_provider_) {
+    switch (
+        remote_suggestions_provider_->snippets_fetcher()->personalization()) {
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kPersonal:
         SendString("switch-personalized", "Only personalized");
         break;
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kBoth:
         SendString("switch-personalized",
                    "Both personalized and non-personalized");
         break;
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kNonPersonal:
         SendString("switch-personalized", "Only non-personalized");
         break;
     }
 
-    SendString("switch-fetch-url",
-               ntp_snippets_service_->snippets_fetcher()->fetch_url().spec());
+    SendString(
+        "switch-fetch-url",
+        remote_suggestions_provider_->snippets_fetcher()->fetch_url().spec());
     web_ui()->CallJavascriptFunctionUnsafe(
         "chrome.SnippetsInternals.receiveJson",
         base::StringValue(
-            ntp_snippets_service_->snippets_fetcher()->last_json()));
+            remote_suggestions_provider_->snippets_fetcher()->last_json()));
   }
 
   SendContentSuggestions();
 }
 
 void SnippetsInternalsMessageHandler::SendClassification() {
   web_ui()->CallJavascriptFunctionUnsafe(
       "chrome.SnippetsInternals.receiveClassification",
       base::StringValue(content_suggestions_service_->user_classifier()
                             ->GetUserClassDescriptionForDebugging()),
@@ skipping 38 matching lines @@
     category_entry->SetString(
         "dismissedContainerId",
         "dismissed-suggestions-" + base::IntToString(category.id()));
     category_entry->SetString("title", info->title());
     category_entry->SetString("status", GetCategoryStatusName(status));
     category_entry->Set("suggestions", std::move(suggestions_list));
     category_entry->Set("dismissedSuggestions", std::move(dismissed_list));
     categories_list->Append(std::move(category_entry));
   }
 
-  if (ntp_snippets_service_) {
+  if (remote_suggestions_provider_) {
     const std::string& status =
-        ntp_snippets_service_->snippets_fetcher()->last_status();
+        remote_suggestions_provider_->snippets_fetcher()->last_status();
     if (!status.empty())
       SendString("hosts-status", "Finished: " + status);
   }
 
   base::DictionaryValue result;
   result.Set("list", std::move(categories_list));
   web_ui()->CallJavascriptFunctionUnsafe(
       "chrome.SnippetsInternals.receiveContentSuggestions", result);
 }
 
@@ skipping 13 matching lines @@
 
 void SnippetsInternalsMessageHandler::OnDismissedSuggestionsLoaded(
     Category category,
     std::vector<ContentSuggestion> dismissed_suggestions) {
   if (dismissed_state_[category] == DismissedState::HIDDEN)
     return;
   dismissed_suggestions_[category] = std::move(dismissed_suggestions);
   dismissed_state_[category] = DismissedState::VISIBLE;
   SendContentSuggestions();
 }