[NTP Snippets] Refactor background scheduling for remote suggestions

components/ntp_snippets/remote/remote_suggestions_hard_scheduler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_HARD_SCHEDULER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_HARD_SCHEDULER_H_

[Marc Treib, 2016/12/08 16:14:58]

The diff is weird (missing) here... do you maybe have a local base branch
without a CL?

[jkrcal, 2016/12/09 09:20:37]

Oh, shit. I've messed up :) The two files you've spotted have leaked into a
totally independent CL https://codereview.chromium.org/2558743003/ (on which I
based this CL because I use the general parsing functions, now).

That CL has unfortunately already landed. No problem for trunk at the moment as
these are new files, not referenced.
Can you see any reasonably simple way to fix it?

Otherwise, can you please just mentally treat both files in review as completely
new, please?

[Marc Treib, 2016/12/09 10:55:37]

Well, I guess the only way would be to land another CL that removes them again.
But since they don't really create any problems, it's probably not worth the
churn. Let's just get this one landed quickly :)
Sure, will do.

 
 #include "base/macros.h"
 #include "base/time/time.h"
 
 namespace ntp_snippets {
 
 // Interface to schedule "hard" periodic fetches of snippets. These "hard"
 // fetches must get triggered according to their schedule independent of whether
 // Chrome is running at that moment.
 class RemoteSuggestionsHardScheduler {
  public:
   // Schedule periodic fetching of snippets, with different periods depending on
   // network state. Once per period, the concrete implementation should call
   // RemoteSuggestionsScheduler::Updater::HardUpdate() where the updater is
   // obtained from ContentSuggestionsService. Any of the periods can be zero to
   // indicate that the corresponding task should not be scheduled.
   virtual bool Schedule(base::TimeDelta period_wifi,
                         base::TimeDelta period_fallback) = 0;
 
-  // Cancel any scheduled tasks.
+  // Cancel any scheduled tasks. Equivalent to Schedule(0, 0).
   virtual bool Unschedule() = 0;
 
  protected:
   RemoteSuggestionsHardScheduler() = default;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RemoteSuggestionsHardScheduler);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_HARD_SCHEDULER_H_