Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2557353002: Add [SameObject] to bring the Budget API in syn with the proposed spec. (Closed)

Created:
4 years ago by harkness
Modified:
4 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add [SameObject] to bring the Budget API in syn with the proposed spec. This adds the [SameObject] tag to the IDL files. The implementation already supported that interface and there is a pre-existing LayoutTest to verify it. This also cleaned up some TODOs that are no longer applicable. BUG=672109 Committed: https://crrev.com/349a449bc6b9cf36dc62224909531e83f89cf5e7 Cr-Commit-Position: refs/heads/master@{#437280}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix html reference in IDL files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/budget/NavigatorBudget.idl View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
harkness
4 years ago (2016-12-08 14:23:43 UTC) #2
Peter Beverloo
lgtm % nits https://codereview.chromium.org/2557353002/diff/1/third_party/WebKit/Source/modules/budget/NavigatorBudget.idl File third_party/WebKit/Source/modules/budget/NavigatorBudget.idl (right): https://codereview.chromium.org/2557353002/diff/1/third_party/WebKit/Source/modules/budget/NavigatorBudget.idl#newcode5 third_party/WebKit/Source/modules/budget/NavigatorBudget.idl:5: // https://wicg.github.io/budget-api/#navigator-budget-interface nit: https://wicg.github.io/budget-api/#navigator-workernavigator-extensions https://codereview.chromium.org/2557353002/diff/1/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl File ...
4 years ago (2016-12-08 14:31:08 UTC) #3
harkness
https://codereview.chromium.org/2557353002/diff/1/third_party/WebKit/Source/modules/budget/NavigatorBudget.idl File third_party/WebKit/Source/modules/budget/NavigatorBudget.idl (right): https://codereview.chromium.org/2557353002/diff/1/third_party/WebKit/Source/modules/budget/NavigatorBudget.idl#newcode5 third_party/WebKit/Source/modules/budget/NavigatorBudget.idl:5: // https://wicg.github.io/budget-api/#navigator-budget-interface On 2016/12/08 14:31:08, Peter Beverloo wrote: > ...
4 years ago (2016-12-08 14:52:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353002/20001
4 years ago (2016-12-08 14:53:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352480)
4 years ago (2016-12-08 16:09:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353002/20001
4 years ago (2016-12-08 16:32:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 17:53:33 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 17:57:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/349a449bc6b9cf36dc62224909531e83f89cf5e7
Cr-Commit-Position: refs/heads/master@{#437280}

Powered by Google App Engine
This is Rietveld 408576698