Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2557343002: Revert of Add a dead zone when dragging tabs horizontally on Mac (Closed)

Created:
4 years ago by Elly Fong-Jones
Modified:
4 years ago
CC:
chromium-reviews, dcheng, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a dead zone when dragging tabs horizontally on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2541653002/ ) Reason for revert: Likely introduced https://crbug.com/672427. Quoting from that bug: """ I believe this is caused by https://codereview.chromium.org/2541653002/: In [TabStripDragController continueDrag:], tabWasDragged_ is still set to YES even if the tab drag is not done because of the newly-introduced horizontal dead zone. Then, in [TabStripDragController endDrag:], the expected target placeholder tab is missing, but tabWasDragged_ is still YES, so [dropController moveTabViews:fromController:] causes a fatality. """ Original issue's description: > Add a dead zone when dragging tabs horizontally on Mac > > When trying to drag tabs vertically out of their windows, they don't drag until the cursor has been moved a certain distance away from the mouse down point. Adding the same behaviour when moving tabs horizontally. > > BUG=90526 > TEST=Create multiple tabs, slowly drag one of them directly to the left or right. It won't actually start moving until it's torn out of its dead zone. > > Committed: https://crrev.com/b74d1db1e9f18844ac6929d6ca7116ef00f0379f > Cr-Commit-Position: refs/heads/master@{#437058} TBR=avi@chromium.org,erikchen@chromium.org,njagsarran@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=90526 Committed: https://crrev.com/a5f08fe95936c084883c03af2028ff1cf034f73e Cr-Commit-Position: refs/heads/master@{#437237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 3 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Elly Fong-Jones
Created Revert of Add a dead zone when dragging tabs horizontally on Mac
4 years ago (2016-12-08 13:58:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557343002/1
4 years ago (2016-12-08 13:58:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 14:00:02 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-08 14:02:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5f08fe95936c084883c03af2028ff1cf034f73e
Cr-Commit-Position: refs/heads/master@{#437237}

Powered by Google App Engine
This is Rietveld 408576698