Chromium Code Reviews
DescriptionRevert of Add a dead zone when dragging tabs horizontally on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2541653002/ )
Reason for revert:
Likely introduced https://crbug.com/672427. Quoting from that bug:
"""
I believe this is caused by https://codereview.chromium.org/2541653002/:
In [TabStripDragController continueDrag:], tabWasDragged_ is still set to YES even if the tab drag is not done because of the newly-introduced horizontal dead zone. Then, in [TabStripDragController endDrag:], the expected target placeholder tab is missing, but tabWasDragged_ is still YES, so [dropController moveTabViews:fromController:] causes a fatality.
"""
Original issue's description:
> Add a dead zone when dragging tabs horizontally on Mac
>
> When trying to drag tabs vertically out of their windows, they don't drag until the cursor has been moved a certain distance away from the mouse down point. Adding the same behaviour when moving tabs horizontally.
>
> BUG=90526
> TEST=Create multiple tabs, slowly drag one of them directly to the left or right. It won't actually start moving until it's torn out of its dead zone.
>
> Committed: https://crrev.com/b74d1db1e9f18844ac6929d6ca7116ef00f0379f
> Cr-Commit-Position: refs/heads/master@{#437058}
TBR=avi@chromium.org,erikchen@chromium.org,njagsarran@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=90526
Committed: https://crrev.com/a5f08fe95936c084883c03af2028ff1cf034f73e
Cr-Commit-Position: refs/heads/master@{#437237}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
||||||||||||||||||||||||||||