Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2557333002: [TypeFeedbackVector] Delete unused DummySlot. (Closed)

Created:
4 years ago by Franzi
Modified:
4 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TypeFeedbackVector] Delete unused DummySlot. BUG= Committed: https://crrev.com/987f63865d7082ad213290cfb669c0d1a7fce058 Cr-Commit-Position: refs/heads/master@{#41598}

Patch Set 1 #

Patch Set 2 : [TypeFeedbackVector] Delete unused constants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/type-feedback-vector.h View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Franzi
Hi Mike, Came across this, seems like it's not needed anymore. PTAL. Thanks, Franzi
4 years ago (2016-12-08 11:31:43 UTC) #8
mvstanton
LGTM. I'm eagerly awaiting ishell's changes to the generic keyed ICs that allow us to ...
4 years ago (2016-12-08 14:04:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557333002/20001
4 years ago (2016-12-08 15:46:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 15:48:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 15:48:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/987f63865d7082ad213290cfb669c0d1a7fce058
Cr-Commit-Position: refs/heads/master@{#41598}

Powered by Google App Engine
This is Rietveld 408576698