Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2557313002: dartfmt dart2js and unittests (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dartfmt dart2js and unittests Using dartfmt version 0.2.13 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/925160e2d0b433befb35821f9e82f84a348a7568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -17 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/compiler/dart2js/enumset_test.dart View 1 chunk +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/diff.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/html_parts.dart View 1 chunk +9 lines, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/output_structure.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
4 years ago (2016-12-08 10:17:23 UTC) #2
sra1
lgtm
4 years ago (2016-12-08 17:44:57 UTC) #4
Johnni Winther
4 years ago (2016-12-09 09:59:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
925160e2d0b433befb35821f9e82f84a348a7568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698