[turbofan] Add NewUnmappedArgumentsElements and NewRestParametersArguments.

[turbofan] Add NewUnmappedArgumentsElements and NewRestParametersArguments.

First step towards making arguments and rest parameters optimizable by
splitting the allocations for the actual object and the elements. The
object allocations can already be escape analyzed this way, the elements
would need special support in the deoptimizer and the escape analysis,
but that can be done as a second separate step.

R=jarin@chromium.org
BUG=v8:5726
Committed: https://crrev.com/0df852780108ec3eeb8055a6a33ee44fe8f5b2fc
Cr-Commit-Position: refs/heads/master@{#41573}

[Benedikt Meurer, 2016-12-08 06:42:26]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 06:42:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 07:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 07:10:56]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-12-08 07:49:22]

lgtm

https://codereview.chromium.org/2557283002/diff/1/src/builtins/builtins-inter...
File src/builtins/builtins-internal.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/builtins/builtins-inter...
src/builtins/builtins-internal.cc:154: Node* offset =
assembler->IntPtrAdd(length, assembler->IntPtrConstant(1));
Why is this defined here? Would not it be enough to put it just before the loop?

https://codereview.chromium.org/2557283002/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:2208:
EffectControlLinearizer::ValueEffectControl
Hmm, we should seriously consider splitting effect control linearizer into the
linearization part and the lowering part. It is getting out of hands.

https://codereview.chromium.org/2557283002/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:321:
STATIC_ASSERT(JSSloppyArgumentsObject::kSize == 5 * kPointerSize);
STATIC_ASSERT -> static_assert (here and below).

[Benedikt Meurer, 2016-12-08 07:58:15]

https://codereview.chromium.org/2557283002/diff/1/src/builtins/builtins-inter...
File src/builtins/builtins-internal.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/builtins/builtins-inter...
src/builtins/builtins-internal.cc:154: Node* offset =
assembler->IntPtrAdd(length, assembler->IntPtrConstant(1));
Indeed.

https://codereview.chromium.org/2557283002/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:2208:
EffectControlLinearizer::ValueEffectControl
On 2016/12/08 07:49:21, Jarin wrote:
> Hmm, we should seriously consider splitting effect control linearizer into the
> linearization part and the lowering part. It is getting out of hands. 

Acknowledged.

https://codereview.chromium.org/2557283002/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2557283002/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:321:
STATIC_ASSERT(JSSloppyArgumentsObject::kSize == 5 * kPointerSize);
On 2016/12/08 07:49:22, Jarin wrote:
> STATIC_ASSERT -> static_assert (here and below).

I think we continue using our STATIC_ASSERT. We should discuss that with
everyone if we want to change.

[Benedikt Meurer, 2016-12-08 07:58:41]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-12-08 07:58:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2557283002/#ps20001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-12-08 07:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:28:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481183921710490,
"parent_rev": "3cb13e65da228d1f326d460c076fcce61a00eff5", "commit_rev":
"ce46b56858d15de9615c89ac4665cfcbe6bc2708"}

[commit-bot: I haz the power, 2016-12-08 08:28:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 08:28:52]

Description was changed from

==========
[turbofan] Add NewUnmappedArgumentsElements and NewRestParametersArguments.

First step towards making arguments and rest parameters optimizable by
splitting the allocations for the actual object and the elements. The
object allocations can already be escape analyzed this way, the elements
would need special support in the deoptimizer and the escape analysis,
but that can be done as a second separate step.

R=jarin@chromium.org
BUG=v8:5726
==========

to

==========
[turbofan] Add NewUnmappedArgumentsElements and NewRestParametersArguments.

First step towards making arguments and rest parameters optimizable by
splitting the allocations for the actual object and the elements. The
object allocations can already be escape analyzed this way, the elements
would need special support in the deoptimizer and the escape analysis,
but that can be done as a second separate step.

R=jarin@chromium.org
BUG=v8:5726

Committed: https://crrev.com/0df852780108ec3eeb8055a6a33ee44fe8f5b2fc
Cr-Commit-Position: refs/heads/master@{#41573}
==========

[commit-bot: I haz the power, 2016-12-08 08:28:53]

Patchset 2 (id:??) landed as
https://crrev.com/0df852780108ec3eeb8055a6a33ee44fe8f5b2fc
Cr-Commit-Position: refs/heads/master@{#41573}