Implements computation of touch calibration transform using user provided data

ash/touch/touch_transformer_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_TOUCH_TOUCH_TRANSFORMER_CONTROLLER_H_
 #define ASH_TOUCH_TOUCH_TRANSFORMER_CONTROLLER_H_
 
 #include <stdint.h>
 
 #include "ash/ash_export.h"
@@ skipping 17 matching lines @@
   ~TouchTransformerController() override;
 
   // Updates the TouchTransformer for touch device and pushes the new
   // TouchTransformer into device manager.
   void UpdateTouchTransformer() const;
 
   // WindowTreeHostManager::Observer:
   void OnDisplaysInitialized() override;
   void OnDisplayConfigurationChanged() override;
 
+  // During touch calibration we remove any kind of transform that is being

[kylechar, 2016/12/22 16:56:00]

You removed this from the cc file but not h file.

[malaykeshav, 2016/12/22 19:48:50]

Done.

+  // applied to the touch input's location.
+  void SetForCalibration(bool is_calibrating);
+
  private:
-  FRIEND_TEST_ALL_PREFIXES(TouchTransformerControllerTest,
-                           MirrorModeLetterboxing);
-  FRIEND_TEST_ALL_PREFIXES(TouchTransformerControllerTest,
-                           MirrorModePillarboxing);
-  FRIEND_TEST_ALL_PREFIXES(TouchTransformerControllerTest, SoftwareMirrorMode);
-  FRIEND_TEST_ALL_PREFIXES(TouchTransformerControllerTest, ExtendedMode);
-  FRIEND_TEST_ALL_PREFIXES(TouchTransformerControllerTest, TouchRadiusScale);
+  friend class TouchTransformerControllerTest;
 
   // Returns a transform that will be used to change an event's location from
   // the touchscreen's coordinate system into |display|'s coordinate system.
   // The transform is also responsible for properly scaling the display if the
   // display supports panel fitting.
   //
   // On X11 events are reported in framebuffer coordinate space, so the
   // |framebuffer_size| is used for scaling.
   // On Ozone events are reported in the touchscreen's resolution, so
   // |touch_display| is used to determine the size and scale the event.
@@ skipping 19 matching lines @@
   // touch events.
   // |touch_display| is the physical display that has the touchscreen
   // from which the events arrive.
   // |target_display| provides the dimensions to which the touch event will be
   // transformed.
   void UpdateTouchTransform(
       int64_t target_display_id,
       const display::ManagedDisplayInfo& touch_display,
       const display::ManagedDisplayInfo& target_display) const;
 
+  bool is_calibrating_ = false;

[kylechar, 2016/12/22 16:56:00]

Likewise, you seem to have removed the usage of this variable but not the
variable.

[malaykeshav, 2016/12/22 19:48:50]

Done

+
   DISALLOW_COPY_AND_ASSIGN(TouchTransformerController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_TOUCH_TOUCH_TRANSFORMER_CONTROLLER_H_