Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2557153002: Fix issues related to a continuous event getting coalesced with a discrete event. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
tdresser
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issues related to a continuous event getting coalesced with a discrete event. Touch move events that are non-cancelable are rAF aligned. But a touch event can get coalesced with a cancelable one which can make a previously rAF aligned event become a discrete event. Ack non-cancelable rAF aligned events right away but allow merging of non-ack required events with ack required events. BUG=670039 Committed: https://crrev.com/74b27c5f8ea554abe9e652ecc51530f9e580c147 Cr-Commit-Position: refs/heads/master@{#437344}

Patch Set 1 #

Patch Set 2 : Update variable name #

Total comments: 4

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -36 lines) Patch
M content/common/input/input_event_dispatch_type.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 3 chunks +11 lines, -7 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 13 chunks +50 lines, -24 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 2 2 chunks +64 lines, -3 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
dtapuska
4 years ago (2016-12-07 21:23:03 UTC) #3
tdresser
LGTM with tiny nits. https://codereview.chromium.org/2557153002/diff/20001/content/renderer/input/main_thread_event_queue_unittest.cc File content/renderer/input/main_thread_event_queue_unittest.cc (right): https://codereview.chromium.org/2557153002/diff/20001/content/renderer/input/main_thread_event_queue_unittest.cc#newcode466 content/renderer/input/main_thread_event_queue_unittest.cc:466: // required event they should ...
4 years ago (2016-12-08 14:31:27 UTC) #8
dtapuska
https://codereview.chromium.org/2557153002/diff/20001/content/renderer/input/main_thread_event_queue_unittest.cc File content/renderer/input/main_thread_event_queue_unittest.cc (right): https://codereview.chromium.org/2557153002/diff/20001/content/renderer/input/main_thread_event_queue_unittest.cc#newcode466 content/renderer/input/main_thread_event_queue_unittest.cc:466: // required event they should be coaelsced together. On ...
4 years ago (2016-12-08 14:46:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557153002/40001
4 years ago (2016-12-08 14:46:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82272)
4 years ago (2016-12-08 15:58:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557153002/40001
4 years ago (2016-12-08 20:22:30 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 21:16:44 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-08 21:19:57 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/74b27c5f8ea554abe9e652ecc51530f9e580c147
Cr-Commit-Position: refs/heads/master@{#437344}

Powered by Google App Engine
This is Rietveld 408576698