Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

Issue 255713008: Change glimage to accept a type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First draft Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
index 5948d76c3521a1a551a60e5cd99ed29951abe36f..5f8afe93bf34b18dc8e20c81b419a26c5871cee1 100644
--- a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
+++ b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
@@ -138,7 +138,7 @@ TEST_F(MockGpuMemoryBufferTest, Lifecycle) {
// Create the image. This should add the image ID to the ImageManager.
GLuint image_id = glCreateImageCHROMIUM(
- kImageWidth, kImageHeight, GL_RGBA8_OES);
+ kImageWidth, kImageHeight, GL_RGBA8_OES, GL_READ_WRITE);
EXPECT_NE(0u, image_id);
EXPECT_TRUE(image_manager_->LookupImage(image_id) != NULL);
@@ -153,8 +153,7 @@ TEST_F(MockGpuMemoryBufferTest, Lifecycle) {
.Times(1)
.WillOnce(Return(shared_memory.memory()))
.RetiresOnSaturation();
- uint8* mapped_buffer = static_cast<uint8*>(
- glMapImageCHROMIUM(image_id, GL_READ_WRITE));
+ uint8* mapped_buffer = static_cast<uint8*>(glMapImageCHROMIUM(image_id));
ASSERT_TRUE(mapped_buffer != NULL);
// Assign a value to each pixel.

Powered by Google App Engine
This is Rietveld 408576698