Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

Issue 255713008: Change glimage to accept a type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt
similarity index 70%
rename from gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
rename to gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt
index 6304fdace0feeb68efe850ed3187722a73ec4ead..154f91e210d5ca763f1f53ba8af40ba2c6406d56 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt
@@ -1,14 +1,14 @@
Name
- CHROMIUM_map_image
+ CHROMIUM_image
Name Strings
- GL_CHROMIUM_map_image
+ GL_CHROMIUM_image
Version
- Last Modifed Date: May 9, 2013
+ Last Modifed Date: Apr 30, 2014
Dependencies
@@ -17,7 +17,9 @@ Dependencies
Overview
This extension allows for more efficient uploading of texture data through
- Chromium's OpenGL ES 2.0 implementation.
+ Chromium's OpenGL ES 2.0 implementation as well as enable hardware overlay
+ support by providing ability to create buffers capable of being scanned out
+ directly by the display controller.
For security reasons Chromium accesses the GPU from a separate process. User
processes are not allowed to access the GPU directly. This multi-process
@@ -34,12 +36,19 @@ Issues
New Tokens
- None
+ Accepted by the <pname> parameter of GetImageParameterivCHROMIUM:
+
+ IMAGE_ROWBYTES_CHROMIUM 0x78F0
+
+ Accepted by the <usage> parameter of CreateImageCHROMIUM:
+
+ IMAGE_MAP_CHROMIUM 0x78F1
+ IMAGE_SCANOUT_CHROMIUM 0x78F2
New Procedures and Functions
- GLuint CreateImageCHROMIUM (GLsizei width, GLsizei height,
- GLenum internalformat)
+ GLuint CreateImageCHROMIUM(GLsizei width, GLsizei height,
+ GLenum internalformat, GLenum usage)
Allocate an image with width equal to <width> and height equal
to <height> stored in format <internalformat>.
@@ -49,27 +58,27 @@ New Procedures and Functions
INVALID_VALUE is generated if <width> or <height> is nonpositive.
- void DestroyImageCHROMIUM (GLuint image_id)
+ INVALID_ENUM is generated if <usage> is not one of
+ IMAGE_MAP_CHROMIUM and IMAGE_SCANOUT_CHROMIUM.
+
+ void DestroyImageCHROMIUM(GLuint image_id)
Frees the image previously allocated by a call to CreateImageCHROMIUM.
INVALID_OPERATION is generated if <image_id> is not a valid image id.
- void* MapImageCHROMIUM (GLuint image_id, GLenum access)
+ void* MapImageCHROMIUM(GLuint image_id)
Returns a pointer to in the user memory for the application to modify
- the image. <access> parameter defines if the user will read or write the
- pixels.
+ the image. It is illegal to call this function on an image not created
+ with IMAGE_MAP_CHROMIUM usage.
INVALID_OPERATION is generated if <image_id> is not a valid image id.
INVALID_OPERATION is generated if the image was already mapped by a previous
call to this method.
- INVALID_ENUM is generated if <access> is not one of WRITE_ONLY, READ_ONLY
- and READ_WRITE.
-
- void UnmapImageCHROMIUM (GLuint image_id)
+ void UnmapImageCHROMIUM(GLuint image_id)
Removes the mapping created by a call to MapImageCHROMIUM.
@@ -105,3 +114,4 @@ New State
Revision History
5/9/2013 Documented the extension
+ 4/30/2014 Moved usage flag to creation function.
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698