Change glimage to accept a type.

ui/gfx/gpu_memory_buffer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_GPU_MEMORY_BUFFER_H_
 #define UI_GFX_GPU_MEMORY_BUFFER_H_
 
 #include "base/memory/shared_memory.h"
 #include "build/build_config.h"
 #include "ui/gfx/gfx_export.h"
@@ skipping 47 matching lines @@
   EGLClientBuffer native_buffer;
   SurfaceTextureId surface_texture_id;
 #endif
 };
 
 // This interface typically correspond to a type of shared memory that is also
 // shared with the GPU. A GPU memory buffer can be written to directly by
 // regular CPU code, but can also be read by the GPU.
 class GFX_EXPORT GpuMemoryBuffer {
  public:
-  enum AccessMode { READ_ONLY, WRITE_ONLY, READ_WRITE };
-
+  enum Usage { READ_WRITE, SCANOUT, USAGE_LAST = SCANOUT };

[reveman, 2014/04/30 11:31:28]

I don't think this needs to be part of this interface anymore. We can just use
the GLenums where needed just like we currently use internalformat GLenums. 

   GpuMemoryBuffer();
   virtual ~GpuMemoryBuffer();
 
   // Maps the buffer into the client's address space so it can be written to by
   // the CPU. This call may block, for instance if the GPU needs to finish
   // accessing the buffer or if CPU caches need to be synchronized. |mode|

[reveman, 2014/04/30 11:31:28]

Please update this comment.

   // indicate how the client intends to use the mapped buffer. Returns NULL on
   // failure.
-  virtual void* Map(AccessMode mode) = 0;
+  virtual void* Map() = 0;
 
   // Unmaps the buffer. It's illegal to use the pointer returned by Map() after
   // this has been called.
   virtual void Unmap() = 0;
 
   // Returns true iff the buffer is mapped.
   virtual bool IsMapped() const = 0;
 
   // Returns the stride in bytes for the buffer.
   virtual uint32 GetStride() const = 0;
 
   // Returns a platform specific handle for this buffer.
   virtual GpuMemoryBufferHandle GetHandle() const = 0;
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_GPU_MEMORY_BUFFER_H_