Change glimage to accept a type.

content/common/gpu/client/gpu_memory_buffer_impl_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shm.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h"
 
 namespace content {
 
 scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImpl::Create(
     gfx::GpuMemoryBufferHandle handle,
     gfx::Size size,
-    unsigned internalformat) {
+    unsigned internalformat,
+    gfx::GpuMemoryBuffer::Usage usage) {
+  if (usage == gfx::GpuMemoryBuffer::SCANOUT)

[reveman, 2014/04/30 11:31:28]

I don't think this should be here. If the browser created some type of handle
for some usage you can assume that it knows what it's doing here. If some
specific implementation doesn't support Map or whatever we can just NOTREACHED
there.

Same comment in other platform specific files.

+    return scoped_ptr<GpuMemoryBufferImpl>();
+
   switch (handle.type) {
     case gfx::SHARED_MEMORY_BUFFER: {
       scoped_ptr<GpuMemoryBufferImplShm> buffer(
           new GpuMemoryBufferImplShm(size, internalformat));
       if (!buffer->Initialize(handle))
         return scoped_ptr<GpuMemoryBufferImpl>();
 
       return buffer.PassAs<GpuMemoryBufferImpl>();
     }
     case gfx::SURFACE_TEXTURE_BUFFER: {
       scoped_ptr<GpuMemoryBufferImplSurfaceTexture> buffer(
           new GpuMemoryBufferImplSurfaceTexture(size, internalformat));
       if (!buffer->Initialize(handle))
         return scoped_ptr<GpuMemoryBufferImpl>();
 
       return buffer.PassAs<GpuMemoryBufferImpl>();
     }
     default:
       return scoped_ptr<GpuMemoryBufferImpl>();
   }
 }
 
 }  // namespace content