Issue 255713007: [Telemetry] Enable adb root on devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255713007: [Telemetry] Enable adb root on devices. (Closed)

Created:
6 years, 8 months ago by tonyg

Modified:
6 years, 8 months ago

Reviewers:
navabi1, navabi

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Enable adb root on devices. The perf bots aren't hitting this explicitly anywhere and provision devices seems like the right place for it. This method outputs a warning, but doesn't fail hard, if root cannot be enabled, for instance on a user build. BUG=366697 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266325

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/provision_devices.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/255713007/1

6 years, 8 months ago (2014-04-26 00:34:49 UTC) #4

Message was sent while issue was closed.

Change committed as 266325

Expand Messages | Collapse Messages