Add chrome://site-tiles-internals/

chrome/browser/ui/webui/site_tiles_internals_ui.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/site_tiles_internals_ui.h"
+
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/browser_process.h"

[Marc Treib, 2016/12/08 15:41:49]

Needed?

[sfiera, 2016/12/08 16:44:34]

Removed.

+#include "chrome/browser/favicon/favicon_service_factory.h"
+#include "chrome/browser/history/top_sites_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/search/suggestions/image_decoder_impl.h"
+#include "chrome/browser/search/suggestions/suggestions_service_factory.h"
+#include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/common/url_constants.h"
+#include "components/grit/components_resources.h"
+#include "components/history/core/browser/top_sites.h"
+#include "components/image_fetcher/image_fetcher_impl.h"
+#include "components/ntp_tiles/icon_cacher.h"
+#include "components/ntp_tiles/most_visited_sites.h"
+#include "components/ntp_tiles/webui/site_tiles_internals_message_handler.h"
+#include "components/ntp_tiles/webui/site_tiles_internals_message_handler_client.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_ui.h"
+#include "content/public/browser/web_ui_data_source.h"
+#include "content/public/browser/web_ui_message_handler.h"
+
+#if defined(OS_ANDROID)
+#include "chrome/browser/android/ntp/popular_sites.h"
+#endif
+
+namespace {
+
+// The implementation for the chrome://site-tiles-internals page.
+class ChromeSiteTilesInternalsMessageHandlerBridge

[Marc Treib, 2016/12/08 15:41:49]

s/Bridge/Client/ ?

[sfiera, 2016/12/08 16:44:34]

Done.

+    : public content::WebUIMessageHandler,
+      public ntp_tiles::SiteTilesInternalsMessageHandlerClient {
+ public:
+  ChromeSiteTilesInternalsMessageHandlerBridge() : handler_(this) {}

[Marc Treib, 2016/12/08 15:41:49]

This is a bit dangerous - if the handler does anything with |this|, things will
probably fail in interesting ways.

Could we maybe pass the pointer over in RegisterMessages?

[sfiera, 2016/12/08 16:44:34]

Sure, done.

+
+ private:
+  // content::WebUIMessageHandler:
+  void RegisterMessages() override;
+
+  // ntp_tiles::SiteTilesInternalsMessageHandlerClient
+  base::SequencedWorkerPool* GetBlockingPool() override;
+  bool IsSourceEnabled(ntp_tiles::NTPTileSource source) override;
+  std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override;
+  std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override;
+  PrefService* GetPrefs() override;
+  void RegisterMessageCallback(
+      const std::string& message,
+      const base::Callback<void(const base::ListValue*)>& callback) override;
+  void CallJavascriptFunctionVector(
+      const std::string& name,
+      const std::vector<const base::Value*>& values) override;
+
+  ntp_tiles::SiteTilesInternalsMessageHandler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeSiteTilesInternalsMessageHandlerBridge);
+};
+
+void ChromeSiteTilesInternalsMessageHandlerBridge::RegisterMessages() {
+  handler_.RegisterMessages();
+}
+
+base::SequencedWorkerPool*
+ChromeSiteTilesInternalsMessageHandlerBridge::GetBlockingPool() {
+  return content::BrowserThread::GetBlockingPool();
+}
+
+bool ChromeSiteTilesInternalsMessageHandlerBridge::IsSourceEnabled(
+    ntp_tiles::NTPTileSource source) {
+  switch (source) {
+    case ntp_tiles::NTPTileSource::TOP_SITES:
+    case ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE:
+#if defined(OS_ANDROID)
+    case ntp_tiles::NTPTileSource::POPULAR:
+#endif
+      return true;
+    default:

[Marc Treib, 2016/12/08 15:41:49]

What about WHITELIST?
Can we get rid of the default, and list all enum values explicitly?

[sfiera, 2016/12/08 16:44:34]

Done.

+      return false;
+  }
+}
+
+std::unique_ptr<ntp_tiles::MostVisitedSites>
+ChromeSiteTilesInternalsMessageHandlerBridge::MakeMostVisitedSites() {
+  // TODO(sfiera): share with Android and Instant in a factory.
+  auto* profile = Profile::FromWebUI(web_ui());
+  return base::MakeUnique<ntp_tiles::MostVisitedSites>(
+      GetPrefs(), TopSitesFactory::GetForProfile(profile),
+      suggestions::SuggestionsServiceFactory::GetForProfile(profile),
+      MakePopularSites(),
+      base::MakeUnique<ntp_tiles::IconCacher>(
+          FaviconServiceFactory::GetForProfile(
+              profile, ServiceAccessType::IMPLICIT_ACCESS),
+          base::MakeUnique<image_fetcher::ImageFetcherImpl>(
+              base::MakeUnique<suggestions::ImageDecoderImpl>(),
+              profile->GetRequestContext())),
+      /*supervisor=*/nullptr);
+}
+
+std::unique_ptr<ntp_tiles::PopularSites>
+ChromeSiteTilesInternalsMessageHandlerBridge::MakePopularSites() {
+#if defined(OS_ANDROID)
+  return ChromePopularSites::NewForProfile(Profile::FromWebUI(web_ui()));
+#else
+  return nullptr;
+#endif
+}
+
+PrefService* ChromeSiteTilesInternalsMessageHandlerBridge::GetPrefs() {
+  return Profile::FromWebUI(web_ui())->GetPrefs();
+}
+
+void ChromeSiteTilesInternalsMessageHandlerBridge::RegisterMessageCallback(
+    const std::string& message,
+    const base::Callback<void(const base::ListValue*)>& callback) {
+  web_ui()->RegisterMessageCallback(message, callback);
+}
+
+void ChromeSiteTilesInternalsMessageHandlerBridge::CallJavascriptFunctionVector(
+    const std::string& name,
+    const std::vector<const base::Value*>& values) {
+  web_ui()->CallJavascriptFunctionUnsafe(name, values);

[Marc Treib, 2016/12/08 15:41:49]

CallJavascriptFunction from WebUIMessageHandler seems to be preferred over this.

[sfiera, 2016/12/08 16:44:34]

Unfortunately it only seems to take arguments by template, not by vector.

Some of the reasoning behind the way things are done in this CL is that I would
like to move the generic stuff that switches between content/ios to some common
location eventually. It's not going to happen until after snippets-internals is
on iOS too and it's clearer what the common part is.

[Marc Treib, 2016/12/08 17:33:22]

Maybe the right solution would be to add a vector overload there? But alright,
can't shave all the yaks :)
Alright, fair enough.

+}
+
+}  // namespace
+
+content::WebUIDataSource* CreateSiteTilesInternalsHTMLSource() {

[Marc Treib, 2016/12/08 15:41:49]

Should this be in the anon namespace?

[sfiera, 2016/12/08 16:44:34]

Done.

+  content::WebUIDataSource* source =
+      content::WebUIDataSource::Create(chrome::kChromeUISiteTilesInternalsHost);
+
+  source->AddResourcePath("site_tiles_internals.js",
+                          IDR_SITE_TILES_INTERNALS_JS);
+  source->AddResourcePath("site_tiles_internals.css",
+                          IDR_SITE_TILES_INTERNALS_CSS);
+  source->SetDefaultResource(IDR_SITE_TILES_INTERNALS_HTML);
+  return source;
+}
+
+SiteTilesInternalsUI::SiteTilesInternalsUI(content::WebUI* web_ui)
+    : WebUIController(web_ui) {
+  content::WebUIDataSource::Add(Profile::FromWebUI(web_ui),
+                                CreateSiteTilesInternalsHTMLSource());
+  web_ui->AddMessageHandler(new ChromeSiteTilesInternalsMessageHandlerBridge);
+}
+
+SiteTilesInternalsUI::~SiteTilesInternalsUI() {}