Add chrome://site-tiles-internals/

ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.h"
+
+#include "components/grit/components_resources.h"
+#include "components/ntp_tiles/field_trial.h"
+#include "components/ntp_tiles/most_visited_sites.h"
+#include "components/ntp_tiles/popular_sites.h"
+#include "components/ntp_tiles/webui/ntp_tiles_internals_message_handler.h"
+#include "components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h"
+#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/chrome_url_constants.h"
+#include "ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.h"
+#include "ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.h"
+#include "ios/web/public/web_thread.h"
+#include "ios/web/public/web_ui_ios_data_source.h"
+#include "ios/web/public/webui/web_ui_ios.h"
+#include "ios/web/public/webui/web_ui_ios_message_handler.h"
+
+namespace {
+
+// The implementation for the chrome://ntp-tiles-internals page.
+class IOSNTPTilesInternalsMessageHandlerBridge
+    : public web::WebUIIOSMessageHandler,
+      public ntp_tiles::NTPTilesInternalsMessageHandlerClient {
+ public:
+  IOSNTPTilesInternalsMessageHandlerBridge() {}
+
+ private:
+  // web::WebUIIOSMessageHandler:
+  void RegisterMessages() override;
+
+  // ntp_tiles::NTPTilesInternalsMessageHandlerClient
+  bool IsSourceEnabled(ntp_tiles::NTPTileSource source) override;
+  std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override;
+  std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override;
+  PrefService* GetPrefs() override;
+  void RegisterMessageCallback(
+      const std::string& message,
+      const base::Callback<void(const base::ListValue*)>& callback) override;
+  void CallJavascriptFunctionVector(
+      const std::string& name,
+      const std::vector<const base::Value*>& values) override;
+
+  ntp_tiles::NTPTilesInternalsMessageHandler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(IOSNTPTilesInternalsMessageHandlerBridge);
+};
+
+void IOSNTPTilesInternalsMessageHandlerBridge::RegisterMessages() {
+  handler_.RegisterMessages(this);
+}
+
+bool IOSNTPTilesInternalsMessageHandlerBridge::IsSourceEnabled(
+    ntp_tiles::NTPTileSource source) {
+  switch (source) {
+    case ntp_tiles::NTPTileSource::TOP_SITES:
+    case ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE:
+      return true;

[noyau (Ping after 24h), 2016/12/12 11:47:40]

The name suggestion service here is highly confusing. This means most likely
right? Should this return true/false depending on the signin state of the user?

[Marc Treib, 2016/12/12 12:03:25]

I don't think so - this methods really just returns "does this source exist"
(and maybe it should be renamed accordingly).
That SuggestionsService (aka Most Likely) will return empty results for
signed-out users is IMO not something that its clients should have to know
about. E.g. ntp_tiles::MostVisitedSites doesn't know or care about signin
status.

[sfiera, 2016/12/12 12:15:38]

Yes. Would you have expected MOST_LIKELY? This enum is shared in several places
but it could be changed.

We also use [CLIENT, SERVER, POPULAR, WHITELIST] in some places, which I like
the brevity of.
No, for a signed-out user, we have a SuggestionsService, so it is enabled, even
though it won't return tiles. This is how the
NTPTilesInternalsMessageHandlerClient interface is defined. "DoesSourceExist()"
sounds better to me.

It would be useful to have the webui get information about the suggestions
service, such as sync and sign-in state. We would first need to know that we
have a valid suggestions service to ask those questions of, though, which is
what this method determines.

[Marc Treib, 2016/12/12 12:18:45]

I think those places are now (mostly?) gone :D
But yes, CLIENT/SERVER is IMO better than TOP_SITES/SUGGESTIONS_SERVICE. Let's
rename the enum at some point.

[sfiera, 2016/12/12 12:29:26]

They're in the histogram names, right? Those feel much more permanent than the
source to me.

[Marc Treib, 2016/12/12 12:34:51]

Ah, I thought you were referring to the old NTPLoggingTileSource enum.
Yes, the histograms say "client"/"server".

+    case ntp_tiles::NTPTileSource::POPULAR:
+      return ntp_tiles::ShouldShowPopularSites();
+    case ntp_tiles::NTPTileSource::WHITELIST:
+      return false;
+  }
+  NOTREACHED();
+  return false;
+}
+
+std::unique_ptr<ntp_tiles::MostVisitedSites>
+IOSNTPTilesInternalsMessageHandlerBridge::MakeMostVisitedSites() {
+  return IOSMostVisitedSitesFactory::NewForBrowserState(
+      ios::ChromeBrowserState::FromWebUIIOS(web_ui()));
+}
+
+std::unique_ptr<ntp_tiles::PopularSites>
+IOSNTPTilesInternalsMessageHandlerBridge::MakePopularSites() {
+  return IOSPopularSitesFactory::NewForBrowserState(
+      ios::ChromeBrowserState::FromWebUIIOS(web_ui()));
+}
+
+PrefService* IOSNTPTilesInternalsMessageHandlerBridge::GetPrefs() {
+  return ios::ChromeBrowserState::FromWebUIIOS(web_ui())->GetPrefs();
+}
+
+void IOSNTPTilesInternalsMessageHandlerBridge::RegisterMessageCallback(
+    const std::string& message,
+    const base::Callback<void(const base::ListValue*)>& callback) {
+  web_ui()->RegisterMessageCallback(message, callback);
+}
+
+void IOSNTPTilesInternalsMessageHandlerBridge::CallJavascriptFunctionVector(
+    const std::string& name,
+    const std::vector<const base::Value*>& values) {
+  web_ui()->CallJavascriptFunction(name, values);
+}
+
+}  // namespace
+
+web::WebUIIOSDataSource* CreateNTPTilesInternalsHTMLSource() {
+  web::WebUIIOSDataSource* source =
+      web::WebUIIOSDataSource::Create(kChromeUINTPTilesInternalsHost);
+
+  source->AddResourcePath("ntp_tiles_internals.js", IDR_NTP_TILES_INTERNALS_JS);
+  source->AddResourcePath("ntp_tiles_internals.css",
+                          IDR_NTP_TILES_INTERNALS_CSS);
+  source->SetDefaultResource(IDR_NTP_TILES_INTERNALS_HTML);
+  return source;
+}
+
+NTPTilesInternalsUI::NTPTilesInternalsUI(web::WebUIIOS* web_ui)
+    : web::WebUIIOSController(web_ui) {
+  web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui),
+                               CreateNTPTilesInternalsHTMLSource());
+  web_ui->AddMessageHandler(new IOSNTPTilesInternalsMessageHandlerBridge);
+}
+
+NTPTilesInternalsUI::~NTPTilesInternalsUI() {}