Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: xfa/fwl/core/cfwl_spinbutton.cpp

Issue 2557103002: Cleanup FWL default values part II. (Closed)
Patch Set: Unused Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/core/cfwl_spinbutton.cpp
diff --git a/xfa/fwl/core/cfwl_spinbutton.cpp b/xfa/fwl/core/cfwl_spinbutton.cpp
index 9c1dc557bd95f71a43402bcb00f62b9394cf2f1b..3e4c9cc71c7135246917e2053b9bdd48f9ad3a60 100644
--- a/xfa/fwl/core/cfwl_spinbutton.cpp
+++ b/xfa/fwl/core/cfwl_spinbutton.cpp
@@ -114,11 +114,8 @@ void CFWL_SpinButton::DrawWidget(CFX_Graphics* pGraphics,
DrawDownButton(pGraphics, pTheme, pMatrix);
}
-void CFWL_SpinButton::EnableButton(bool bEnable, bool bUp) {
- if (bUp)
- m_dwUpState = bEnable ? CFWL_PartState_Normal : CFWL_PartState_Disabled;
- else
- m_dwDnState = bEnable ? CFWL_PartState_Normal : CFWL_PartState_Disabled;
+void CFWL_SpinButton::DisableButton() {
+ m_dwDnState = CFWL_PartState_Disabled;
}
bool CFWL_SpinButton::IsButtonEnabled(bool bUp) {
@@ -296,7 +293,7 @@ void CFWL_SpinButton::OnMouseMove(CFWL_MsgMouse* pMsg) {
}
}
if (!IsButtonEnabled(false))
Tom Sepez 2016/12/07 17:33:32 This just reads strangely ... sounds like a no-op?
dsinclair 2016/12/07 18:28:49 Done.
- EnableButton(false, false);
+ DisableButton();
} else if (m_rtDnButton.Contains(pMsg->m_fx, pMsg->m_fy)) {
if (IsButtonEnabled(false)) {

Powered by Google App Engine
This is Rietveld 408576698