LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html - Issue 25571006: Fix out-of-date offset in selection range code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

Issue 25571006: Fix out-of-date offset in selection range code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Better test. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

diff --git a/LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html b/LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

index d817d98d28eba8ba2e0515fc3ac5363fcd44d73e..18194989f0fc976abe010a04d3912d33fff8f679 100644

--- a/LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

+++ b/LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

@@ -2,26 +2,24 @@

<html>

<body>

- <script>

- window.onload = function(){

- var range = document.createRange();

- var rootNode = document.getElementById("root");

- range.setStart(rootNode, 4);

- range.setEnd(rootNode, 6);

- var parentElement = document.getElementById("targetForSurround");

- range.surroundContents(parentElement);

- shouldBe(range.startContainer.id, rootNode.id);

- shouldBe(range.startOffset.toString(), "3");

- shouldBe(range.endContainer.id, rootNode.id);

- shouldBe(range.startOffset.toString(), "3");

- };

- </script>

- <script src="../../fast/js/resources/js-test-post.js"></script>

<div id="description">Test that there is no crash when surroundContents is called with a node preceding the current selection.</div>

</div>

+ <script>

+ var range = document.createRange();

+ var rootNode = document.getElementById("root");

+ range.setStart(rootNode, 4);

+ range.setEnd(rootNode, 6);

+ var parentElement = document.getElementById("targetForSurround");

+ range.surroundContents(parentElement);

+ shouldBe('range.startContainer.id', 'rootNode.id');

+ shouldBe('range.startOffset', '3');

+ shouldBe('range.endContainer.id', 'rootNode.id');

+ shouldBe('range.startOffset', '3');

+ </script>

+ <script src="../../fast/js/resources/js-test-post.js"></script>

</body>

</html>

« no previous file with comments | « no previous file | LayoutTests/editing/selection/range-surroundContents-with-preceding-node-expected.txt » ('j') | no next file with comments »