LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html - Issue 25571006: Fix out-of-date offset in selection range code.

Side by Side Diff: LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

Issue 25571006: Fix out-of-date offset in selection range code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Test with description. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script>

	5 window.onload = function(){

	6 var oSelection=window.getSelection();
	yosin_UTC9 2013/10/03 01:41:19 nit: indentation of JavaScript should be four spac nit: indentation of JavaScript should be four spaces. nit: Could you remove prefix "o"? yosin_UTC9 2013/10/03 01:41:19 Could you populate Range object by script rather t Could you populate Range object by script rather than using selection? We don't want to have dependency from core/dom to core/editing. Stephen Chennney 2013/10/03 20:38:28 Done. Show quoted text On 2013/10/03 01:41:19, Yoshifumi Inoue wrote: > nit: indentation of JavaScript should be four spaces. > nit: Could you remove prefix "o"? Done.
	7 document.execCommand("SelectAll", false);

	8 var oRange = oSelection.getRangeAt(0);

	9 var aoElements = document.getElementsByTagName("*");

	10 var oParentElement = aoElements[5];
	ojan 2013/10/03 02:15:15 It would be easier to understand what this test is It would be easier to understand what this test is doing if you put an id on the element and called getElementById instead of getElementsByTagName. As it is, it's hard to see which element we're passing to surround contents. Stephen Chennney 2013/10/03 20:38:28 Done. Show quoted text On 2013/10/03 02:15:15, ojan wrote: > It would be easier to understand what this test is doing if you put an id on the > element and called getElementById instead of getElementsByTagName. As it is, > it's hard to see which element we're passing to surround contents. Done.
	11 oRange.surroundContents(oParentElement);

	12

	13 var descriptionNode = document.createElement("p");

	14 descriptionNode.id = "description";

	15 descriptionNode.innerHTML = "Test that there is no crash when surroundCo ntents is called with a node preceding the current selection.";

	16 var buttonNode = document.getElementById("root");

	17 buttonNode.insertBefore(descriptionNode, buttonNode.firstChild);

	18 Markup.dump("root");
	ojan 2013/10/03 02:15:15 Can you call Markup.dump before you insert the des Can you call Markup.dump before you insert the description (i.e. after line 11)? That would make the output much easier to read. Stephen Chennney 2013/10/03 20:38:28 Switched to js-tests. Show quoted text On 2013/10/03 02:15:15, ojan wrote: > Can you call Markup.dump before you insert the description (i.e. after line 11)? > That would make the output much easier to read. Switched to js-tests.
	19 };

	20 </script>

	21 <button id="root">

	22 <div></div>

	23 <div></div>

	24 <table></table>

	25 </button>

	26 <script src="../../resources/dump-as-markup.js"></script>
	yosin_UTC9 2013/10/03 01:41:19 It is better to use js-test-pre.js rather than dum It is better to use js-test-pre.js rather than dump-as-markup.js. Because, we can see what we expected in JavaScript code: shouldBeEqulaToStirng('parentElement.outerHTML', '<div>.....</div>'); Stephen Chennney 2013/10/03 20:38:28 Done. Show quoted text On 2013/10/03 01:41:19, Yoshifumi Inoue wrote: > It is better to use js-test-pre.js rather than dump-as-markup.js. Because, we > can see what we expected in JavaScript code: > > shouldBeEqulaToStirng('parentElement.outerHTML', '<div>.....</div>'); Done.
	27 </body>

	28 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/range-surroundContents-with-preceding-node-expected.txt » ('j') | Source/core/dom/Range.cpp » ('J')