LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html - Issue 25571006: Fix out-of-date offset in selection range code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/range-surroundContents-with-preceding-node.html

Issue 25571006: Fix out-of-date offset in selection range code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script>

	5 if (window.testRunner)

	6 {

	7 testRunner.dumpAsText();

	8 testRunner.waitUntilDone();

	9 }

	10

	11 setTimeout(function(){
	ojan 2013/10/02 17:56:34 Is this setTimeout really needed? Perhaps this cod Is this setTimeout really needed? Perhaps this code is just trying to run after the button has parsed? Can you move this code to window.onload or in a script tag after the <button> instead? You may need a document.body.offsetHeight to force a layout first. In general, setTimeout is a red flag for flaky test. Best to only use it where absolutely necessary. Also, can you make this test verify the new behavior is correct since it looks like your patch fixes a bug beyond just fixing the crash? You could make it a dump-as-markup test pretty easily.
	12 var oSelection=window.getSelection();

	13 document.execCommand("SelectAll", false);

	14 var oRange = oSelection.getRangeAt(0);

	15 var aoElements = document.getElementsByTagName("*");

	16 var oParentElement = aoElements[5];

	17 oRange.surroundContents(oParentElement);

	18

	19 document.body.innerHTML = "Test should not assert when an element before the selection range is moved to the last element in the selection range via sur roundContents.";

	20

	21 if (window.testRunner)

	22 testRunner.notifyDone();

	23 }, 1);

	24 </script>

	25 <button>

	26 <div></div>

	27 <div></div>

	28 <table></table>

	29 </button>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/selection/range-surroundContents-with-preceding-node-expected.txt » ('j') | no next file with comments »