Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 25571005: DevTools: Never instantiate DevToolsAgentHost on threads other than UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index db30d26a9870887846191667aa244cf07ce2cf90..e8035a3a0ebc519efc7ed64e6f86f2444d37adeb 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -526,16 +526,15 @@ void DevToolsHttpHandlerImpl::OnJsonRequestUI(
target_list->Append(SerializePageInfo(i->first, host));
AddRef(); // Balanced in SendTargetList.
- BrowserThread::PostTaskAndReply(
+ BrowserThread::PostTaskAndReplyWithResult(
BrowserThread::IO,
FROM_HERE,
base::Bind(&DevToolsHttpHandlerImpl::CollectWorkerInfo,
- base::Unretained(this),
- target_list,
- host),
+ base::Unretained(this)),
base::Bind(&DevToolsHttpHandlerImpl::SendTargetList,
base::Unretained(this),
connection_id,
+ host,
target_list));
return;
}
@@ -585,18 +584,18 @@ void DevToolsHttpHandlerImpl::OnJsonRequestUI(
return;
}
-void DevToolsHttpHandlerImpl::CollectWorkerInfo(base::ListValue* target_list,
- std::string host) {
-
- std::vector<WorkerService::WorkerInfo> worker_info =
- WorkerService::GetInstance()->GetWorkers();
+DevToolsHttpHandlerImpl::WorkerInfoList
+DevToolsHttpHandlerImpl::CollectWorkerInfo() {
+ return WorkerService::GetInstance()->GetWorkers();
+}
+void DevToolsHttpHandlerImpl::SendTargetList(
+ int connection_id,
+ const std::string& host,
+ base::ListValue* target_list,
+ const WorkerInfoList& worker_info) {
for (size_t i = 0; i < worker_info.size(); ++i)
target_list->Append(SerializeWorkerInfo(worker_info[i], host));
-}
-
-void DevToolsHttpHandlerImpl::SendTargetList(int connection_id,
- base::ListValue* target_list) {
SendJson(connection_id, net::HTTP_OK, target_list, std::string());
delete target_list;
Release(); // Balanced OnJsonRequestUI.
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698