Issue 25571005: DevTools: Never instantiate DevToolsAgentHost on threads other than UI

Issue 25571005: DevTools: Never instantiate DevToolsAgentHost on threads other than UI (Closed)

Created:
7 years, 2 months ago by Vladislav Kaznacheev

Modified:
7 years, 2 months ago

Reviewers:
Matt Perry, pfeldman

CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: Never instantiate DevToolsAgentHost on threads other than UI BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226622

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -26 lines)			Patch
M	chrome/browser/extensions/api/debugger/debugger_api.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/debugger/debugger_api.cc	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	content/browser/devtools/devtools_agent_host_impl.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/browser/devtools/devtools_http_handler_impl.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	content/browser/devtools/devtools_http_handler_impl.cc	View	2 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/25571005/1

7 years, 2 months ago (2013-10-02 15:01:17 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=28444

7 years, 2 months ago (2013-10-02 15:17:41 UTC) #4

Vladislav Kaznacheev

Hi Matt, Please review changes to: chrome/browser/extensions/api/debugger/debugger_api.h chrome/browser/extensions/api/debugger/debugger_api.cc Thanks, Vlad

7 years, 2 months ago (2013-10-02 18:04:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/25571005/1

7 years, 2 months ago (2013-10-02 20:12:05 UTC) #7

Message was sent while issue was closed.

Change committed as 226622

Expand Messages | Collapse Messages