src/typing.cc - Issue 25571002: Revert "Hydrogenisation of binops"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 25571002: Revert "Hydrogenisation of binops" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index e9da680c32cd3ec025e80137e91b8a34fefd3dc4..3fd1ce50577df691f288f55423f6ab19bbc089d1 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -543,7 +543,7 @@ void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {

Handle<Type> type, left_type, right_type;

Maybe<int> fixed_right_arg;

oracle()->BinaryType(expr->BinaryOperationFeedbackId(),

- &left_type, &right_type, &type, &fixed_right_arg, expr->op());

+ &left_type, &right_type, &type, &fixed_right_arg);

NarrowLowerType(expr, type);

NarrowLowerType(expr->left(), left_type);

NarrowLowerType(expr->right(), right_type);

« no previous file with comments | « src/type-info.cc ('k') | src/v8-counters.h » ('j') | no next file with comments »