Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/detailed_build_info.js
diff --git a/chrome/browser/resources/settings/about_page/detailed_build_info.js b/chrome/browser/resources/settings/about_page/detailed_build_info.js
index ab301700ec3036ca490badaaf5987f80ffab750f..e6d93374c541730f794152e6dcca046afd56c3ed 100644
--- a/chrome/browser/resources/settings/about_page/detailed_build_info.js
+++ b/chrome/browser/resources/settings/about_page/detailed_build_info.js
@@ -55,8 +55,12 @@ Polymer({
return version.length > 0;
},
- /** @private */
- onChangeChannelTap_: function() {
+ /**
+ * @param {!Event} e The polymer event.
dpapad 2016/12/07 20:00:50 Nit (optional): Perhaps drop the "The polymer even
hcarmona 2016/12/08 20:12:50 Done.
+ * @private
+ */
+ onChangeChannelTap_: function(e) {
+ e.preventDefault();
this.showChannelSwitcherDialog_ = true;
// Async to wait for dialog to appear in the DOM.
this.async(function() {
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698