chrome/browser/resources/settings/people_page/people_page.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/people_page/people_page.js

diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js

index 124614dd46406724a26546ab01b94d03982dac20..07511f35c83a2116b2d0dc92839e1a845ff3c3fe 100644

--- a/chrome/browser/resources/settings/people_page/people_page.js

+++ b/chrome/browser/resources/settings/people_page/people_page.js

@@ -335,8 +335,12 @@ Polymer({

this.easyUnlockBrowserProxy_.startTurnOnFlow();

- /** @private */

- onEasyUnlockTurnOffTap_: function() {

+ /**

+ * @param {Event} e The polymer event.

dpapad 2016/12/07 18:17:06 Nit: !Event here and elsewhere.

hcarmona 2016/12/07 18:52:18 Done.

+ * @private

+ */

+ onEasyUnlockTurnOffTap_: function(e) {

+ e.preventDefault();

this.showEasyUnlockTurnOffDialog_ = true;