Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/resources/settings/reset_page/reset_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-reset-page' is the settings page containing reset 7 * 'settings-reset-page' is the settings page containing reset
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 settings.navigateTo(settings.Route.RESET_DIALOG, 55 settings.navigateTo(settings.Route.RESET_DIALOG,
56 new URLSearchParams('origin=userclick')); 56 new URLSearchParams('origin=userclick'));
57 }, 57 },
58 58
59 /** @private */ 59 /** @private */
60 onResetProfileDialogClose_: function() { 60 onResetProfileDialogClose_: function() {
61 settings.navigateToPreviousRoute(); 61 settings.navigateToPreviousRoute();
62 }, 62 },
63 63
64 <if expr="chromeos"> 64 <if expr="chromeos">
65 /** @private */ 65 /**
66 onShowPowerwashDialog_: function() { 66 * @param {!Event} e
67 * @private
68 */
69 onShowPowerwashDialog_: function(e) {
70 e.preventDefault();
67 this.showPowerwashDialog_ = true; 71 this.showPowerwashDialog_ = true;
68 }, 72 },
69 73
70 /** @private */ 74 /** @private */
71 onPowerwashDialogClose_: function() { 75 onPowerwashDialogClose_: function() {
72 this.showPowerwashDialog_ = false; 76 this.showPowerwashDialog_ = false;
73 }, 77 },
74 </if> 78 </if>
75 }); 79 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698