Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/resources/settings/people_page/lock_screen.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-lock-screen' allows the user to change how they unlock their 7 * 'settings-lock-screen' allows the user to change how they unlock their
8 * device. 8 * device.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 return selectedUnlockType === LockScreenUnlockType.PIN_PASSWORD; 111 return selectedUnlockType === LockScreenUnlockType.PIN_PASSWORD;
112 }, 112 },
113 113
114 /** @private */ 114 /** @private */
115 getSetupPinText_: function() { 115 getSetupPinText_: function() {
116 if (this.hasPin) 116 if (this.hasPin)
117 return this.i18n('lockScreenChangePinButton'); 117 return this.i18n('lockScreenChangePinButton');
118 return this.i18n('lockScreenSetupPinButton'); 118 return this.i18n('lockScreenSetupPinButton');
119 }, 119 },
120 120
121 /** @private */ 121 /**
122 onConfigurePin_: function() { 122 * @param {!Event} e
123 * @private
124 */
125 onConfigurePin_: function(e) {
126 e.preventDefault();
123 this.$.setupPin.open(); 127 this.$.setupPin.open();
124 }, 128 },
125 }); 129 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698