Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-people-page' is the settings page containing sign-in settings. 7 * 'settings-people-page' is the settings page containing sign-in settings.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-people-page', 10 is: 'settings-people-page',
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 /** @private */ 328 /** @private */
329 onConfigureLockTap_: function() { 329 onConfigureLockTap_: function() {
330 settings.navigateTo(settings.Route.LOCK_SCREEN); 330 settings.navigateTo(settings.Route.LOCK_SCREEN);
331 }, 331 },
332 332
333 /** @private */ 333 /** @private */
334 onEasyUnlockSetupTap_: function() { 334 onEasyUnlockSetupTap_: function() {
335 this.easyUnlockBrowserProxy_.startTurnOnFlow(); 335 this.easyUnlockBrowserProxy_.startTurnOnFlow();
336 }, 336 },
337 337
338 /** @private */ 338 /**
339 onEasyUnlockTurnOffTap_: function() { 339 * @param {Event} e The polymer event.
dpapad 2016/12/07 18:17:06 Nit: !Event here and elsewhere.
hcarmona 2016/12/07 18:52:18 Done.
340 * @private
341 */
342 onEasyUnlockTurnOffTap_: function(e) {
343 e.preventDefault();
340 this.showEasyUnlockTurnOffDialog_ = true; 344 this.showEasyUnlockTurnOffDialog_ = true;
341 }, 345 },
342 346
343 /** @private */ 347 /** @private */
344 onEasyUnlockTurnOffDialogClose_: function() { 348 onEasyUnlockTurnOffDialogClose_: function() {
345 this.showEasyUnlockTurnOffDialog_ = false; 349 this.showEasyUnlockTurnOffDialog_ = false;
346 }, 350 },
347 </if> 351 </if>
348 352
349 /** @private */ 353 /** @private */
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 467
464 /** 468 /**
465 * @param {!settings.SyncStatus} syncStatus 469 * @param {!settings.SyncStatus} syncStatus
466 * @return {boolean} Whether to show the "Sign in to Chrome" button. 470 * @return {boolean} Whether to show the "Sign in to Chrome" button.
467 * @private 471 * @private
468 */ 472 */
469 showSignin_: function(syncStatus) { 473 showSignin_: function(syncStatus) {
470 return !!syncStatus.signinAllowed && !syncStatus.signedIn; 474 return !!syncStatus.signinAllowed && !syncStatus.signedIn;
471 }, 475 },
472 }); 476 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698