Upgrade Insecure Requests: bugfixes, tests, and support for OOPIF.

content/browser/frame_host/frame_tree_node.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 149 matching lines @@
   void AddContentSecurityPolicy(const ContentSecurityPolicyHeader& header);
 
   // Discards previous CSP headers and notifies proxies about the update.
   // Typically invoked after committing navigation to a new document (since the
   // new document comes with a fresh set of CSP http headers).
   void ResetContentSecurityPolicy();
 
   // Sets the current insecure request policy, and notifies proxies about the
   // update.
   void SetInsecureRequestPolicy(blink::WebInsecureRequestPolicy policy);
+  void SetInsecureNavigationsSet(
+      const std::vector<unsigned>& insecure_navigations_set);

[nasko, 2016/12/08 22:45:44]

Please be explicit. Unsigned int?

[arthursonzogni, 2016/12/09 11:06:50]

I agree, but at the same time I tried to stay coherent with what is done in the
current source code:
* using InsecureNavigationsSet = HashSet<unsigned, WTF::AlreadyHashed>;
* unsigned StringImpl::hash() const
* void addInsecureNavigationUpgrade(unsigned hashedHost)

I think "unsigned" is more used in blink:
grep "<unsigned int>"    -r third_party/WebKit/ | wc -l => 0
grep "<unsigned>"        -r third_party/WebKit/ | wc -l => 454
grep "unsigned int i ="  -r third_party/WebKit/ | wc -l => 2
grep "unsigned i ="      -r third_party/WebKit/ | wc -l => 789

There is no consensus in content/
grep "<unsigned int>"    -r content/ | wc -l => 24
grep "<unsigned>"        -r content/ | wc -l => 18
grep "unsigned int i ="  -r content/ | wc -l => 6
grep "unsigned i ="      -r content/ | wc -l => 32


I think the best thing to do is to apply your suggestion to my patch for
everything that is not in blink. Are you okay with this?

 
   // Returns the currently active sandbox flags for this frame.  This includes
   // flags inherited from parent frames and the currently active flags from the
   // <iframe> element hosting this frame.  This does not include flags that
   // have been updated in an <iframe> element but have not taken effect yet;
   // use pending_sandbox_flags() for those.
   blink::WebSandboxFlags effective_sandbox_flags() const {
     return replication_state_.sandbox_flags;
   }
 
@@ skipping 198 matching lines @@
   // browser process activities to this node (when possible).  It is unrelated
   // to the core logic of FrameTreeNode.
   FrameTreeNodeBlameContext blame_context_;
 
   DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_