Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: test/mjsunit/debug-clearbreakpoint.js

Issue 2557043005: [debugger] remove remaining uses of the debug command processor. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/debug-changebreakpoint.js ('k') | test/mjsunit/debug-clearbreakpointgroup.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/debug-clearbreakpoint.js
diff --git a/test/mjsunit/debug-clearbreakpoint.js b/test/mjsunit/debug-clearbreakpoint.js
index 58e1531a10493595eee290b0c5ac5af14779b79a..e7d2a1473cb50c1593029b0ba5f0381899728cb2 100644
--- a/test/mjsunit/debug-clearbreakpoint.js
+++ b/test/mjsunit/debug-clearbreakpoint.js
@@ -34,53 +34,15 @@ listenerComplete = false;
exception = false;
var breakpoint = -1;
-var base_request = '"seq":0,"type":"request","command":"clearbreakpoint"'
-
-function safeEval(code) {
- try {
- return eval('(' + code + ')');
- } catch (e) {
- assertEquals(void 0, e);
- return undefined;
- }
-}
-
-function testArguments(dcp, arguments, success) {
- var request = '{' + base_request + ',"arguments":' + arguments + '}'
- var json_response = dcp.processDebugJSONRequest(request);
- var response = safeEval(json_response);
- if (success) {
- assertTrue(response.success, json_response);
- } else {
- assertFalse(response.success, json_response);
- }
-}
function listener(event, exec_state, event_data, data) {
try {
- if (event == Debug.DebugEvent.Break) {
- // Get the debug command processor.
- var dcp = exec_state.debugCommandProcessor("unspecified_running_state");
-
- // Test some illegal clearbreakpoint requests.
- var request = '{' + base_request + '}'
- var response = safeEval(dcp.processDebugJSONRequest(request));
- assertFalse(response.success);
-
- testArguments(dcp, '{}', false);
- testArguments(dcp, '{"breakpoint":0}', false);
- testArguments(dcp, '{"breakpoint":' + (breakpoint + 1)+ '}', false);
- testArguments(dcp, '{"breakpoint":"xx"}', false);
-
- // Test some legal clearbreakpoint requests.
- testArguments(dcp, '{"breakpoint":' + breakpoint + '}', true);
-
- // Cannot clear the same break point twice.
- testArguments(dcp, '{"breakpoint":' + breakpoint + '}', false);
-
- // Indicate that all was processed.
- listenerComplete = true;
- }
+ if (event == Debug.DebugEvent.Break) {
+ // Clear once.
+ Debug.clearBreakPoint(breakpoint);
+ // Indicate that all was processed.
+ listenerComplete = true;
+ }
} catch (e) {
exception = e
};
« no previous file with comments | « test/mjsunit/debug-changebreakpoint.js ('k') | test/mjsunit/debug-clearbreakpointgroup.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698